[Bibdesk-commit] SF.net SVN: bibdesk:[26828] trunk/bibdesk/BDSKLinkedFile.m

[hofman--- via Bibdesk-commit]

Revision: 26828
          http://sourceforge.net/p/bibdesk/svn/26828
Author:   hofman
Date:     2021-09-08 09:59:00 +0000 (Wed, 08 Sep 2021)
Log Message:
-----------
Don't need basePath to update the bookmark

Modified Paths:
--------------
    trunk/bibdesk/BDSKLinkedFile.m

Modified: trunk/bibdesk/BDSKLinkedFile.m
===================================================================
--- trunk/bibdesk/BDSKLinkedFile.m      2021-09-08 09:43:19 UTC (rev 26827)
+++ trunk/bibdesk/BDSKLinkedFile.m      2021-09-08 09:59:00 UTC (rev 26828)
@@ -525,13 +525,11 @@
     }
 }
 
-- (void)updateBookmarkWithBasePath:(NSString *)basePath {
+- (void)updateBookmark {
     BDSKASSERT(fileURL != nil);
-    BDSKASSERT(basePath != nil);
     BDSKASSERT(wantsBookmark);
     
     // update the bookmark
-    NSURL *baseURL = basePath ? [NSURL fileURLWithPath:basePath 
isDirectory:YES] : nil;
     NSData *data = BDSKCreateBookmarkDataFromURL(fileURL ?: [fileRef 
filePathURL]);
     if (data) {
         [alias release];
@@ -595,7 +593,7 @@
                 if (fileURL == nil)
                     fileURL = [aURL retain];
                 if (shouldUpdate) {
-                    [self updateBookmarkWithBasePath:basePath];
+                    [self updateBookmark];
                     [self setRelativePath:[aURL path] fromPath:basePath];
                 }
                 [aURL release];
@@ -684,7 +682,7 @@
                 aURL = [self newPathURL];
                 NSString *basePath = [delegate basePathForLinkedFile:self];
                 if (basePath) {
-                    [self updateBookmarkWithBasePath:basePath];
+                    [self updateBookmark];
                     [self setRelativePath:[aURL path] fromPath:basePath];
                 }
             }
@@ -845,7 +843,7 @@
                         [self setRelativePath:[aURL path] fromPath:basePath];
                     }
                 } else if (basePath) {
-                    [self updateBookmarkWithBasePath:basePath];
+                    [self updateBookmark];
                     [self setRelativePath:[aURL path] fromPath:basePath];
                 }
             }
@@ -883,7 +881,7 @@
                 }
                 if (needsUpdate) {
                     if (basePath) {
-                        [self updateBookmarkWithBasePath:basePath];
+                        [self updateBookmark];
                         [self setRelativePath:aPath fromPath:basePath];
                     } else {
                         [self setAliasOrBookmarkWithPath:aPath 
basePath:basePath];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit