Revision: 27506
http://sourceforge.net/p/bibdesk/svn/27506
Author: hofman
Date: 2022-05-30 23:21:25 +0000 (Mon, 30 May 2022)
Log Message:
-----------
rename newValues property to values, to avoid retainment problems
Modified Paths:
--------------
trunk/bibdesk/BDSKScriptHook+Scripting.m
trunk/bibdesk/BDSKScriptHook.h
trunk/bibdesk/BDSKScriptHook.m
trunk/bibdesk/BibDocument.m
Modified: trunk/bibdesk/BDSKScriptHook+Scripting.m
===================================================================
--- trunk/bibdesk/BDSKScriptHook+Scripting.m 2022-05-30 22:56:54 UTC (rev
27505)
+++ trunk/bibdesk/BDSKScriptHook+Scripting.m 2022-05-30 23:21:25 UTC (rev
27506)
@@ -71,7 +71,7 @@
}
- (NSArray *)scriptingNewValues {
- return newValues ?: [NSArray array];
+ return values ?: [NSArray array];
}
@end
Modified: trunk/bibdesk/BDSKScriptHook.h
===================================================================
--- trunk/bibdesk/BDSKScriptHook.h 2022-05-30 22:56:54 UTC (rev 27505)
+++ trunk/bibdesk/BDSKScriptHook.h 2022-05-30 23:21:25 UTC (rev 27506)
@@ -60,7 +60,7 @@
NSUserAppleScriptTask *script;
NSString *field;
NSArray *oldValues;
- NSArray *newValues;
+ NSArray *values;
BOOL cancelled;
BibDocument *document;
}
@@ -77,8 +77,7 @@
@property (nonatomic, readonly) NSString *uniqueID;
@property (nonatomic, retain) NSString *field;
@property (nonatomic, retain) NSArray *oldValues;
-@property (nonatomic, retain) NSArray *newValues;
-- (NSArray *)newValues __attribute__((objc_method_family(none)));
+@property (nonatomic, retain) NSArray *values;
@property (nonatomic) BOOL cancelled;
@property (nonatomic, retain) BibDocument *document;
@property (nonatomic, readonly) NSUserAppleScriptTask *script;
Modified: trunk/bibdesk/BDSKScriptHook.m
===================================================================
--- trunk/bibdesk/BDSKScriptHook.m 2022-05-30 22:56:54 UTC (rev 27505)
+++ trunk/bibdesk/BDSKScriptHook.m 2022-05-30 23:21:25 UTC (rev 27506)
@@ -65,7 +65,7 @@
@implementation BDSKScriptHook
-@synthesize name, uniqueID, field, oldValues, newValues, cancelled, document,
script;
+@synthesize name, uniqueID, field, oldValues, values, cancelled, document,
script;
static NSMutableDictionary *scriptHooks = nil;
@@ -142,7 +142,7 @@
script = [aScript retain];
field = nil;
oldValues = nil;
- newValues = nil;
+ values = nil;
cancelled = NO;
document = nil;
}
@@ -156,7 +156,7 @@
BDSKDESTROY(script);
BDSKDESTROY(field);
BDSKDESTROY(oldValues);
- BDSKDESTROY(newValues);
+ BDSKDESTROY(values);
BDSKDESTROY(document);
[super dealloc];
}
Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m 2022-05-30 22:56:54 UTC (rev 27505)
+++ trunk/bibdesk/BibDocument.m 2022-05-30 23:21:25 UTC (rev 27506)
@@ -2674,7 +2674,7 @@
[scriptHook setDocument:self];
[scriptHook setField:field];
[scriptHook setOldValues:oldValues];
- [scriptHook setNewValues:newValues];
+ [scriptHook setValues:newValues];
[scriptHook runWithPublications:items completionHandler:handler];
[scriptHook release];
} else if (handler) {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
