Revision: 27851
http://sourceforge.net/p/bibdesk/svn/27851
Author: hofman
Date: 2022-08-31 14:31:17 +0000 (Wed, 31 Aug 2022)
Log Message:
-----------
don't notify update to reload external group when setting nil publications from
nil, not just for shared groups
Modified Paths:
--------------
trunk/bibdesk/BDSKExternalGroup.m
trunk/bibdesk/BDSKSharedGroup.m
Modified: trunk/bibdesk/BDSKExternalGroup.m
===================================================================
--- trunk/bibdesk/BDSKExternalGroup.m 2022-08-30 18:00:57 UTC (rev 27850)
+++ trunk/bibdesk/BDSKExternalGroup.m 2022-08-31 14:31:17 UTC (rev 27851)
@@ -109,7 +109,7 @@
}
- (void)setPublications:(NSArray *)newPublications {
- NSMutableArray *addedPubs = [[NSMutableArray alloc] init];
+ NSMutableArray *addedPubs = newPublications == nil && publications == nil
? nil : [[NSMutableArray alloc] init];
NSMutableArray *removedPubs = nil;
if (newPublications != publications) {
Modified: trunk/bibdesk/BDSKSharedGroup.m
===================================================================
--- trunk/bibdesk/BDSKSharedGroup.m 2022-08-30 18:00:57 UTC (rev 27850)
+++ trunk/bibdesk/BDSKSharedGroup.m 2022-08-31 14:31:17 UTC (rev 27851)
@@ -200,13 +200,8 @@
[pubs setValue:macroResolver forKey:@"macroResolver"];
[[self macroResolver] setMacroDefinitions:macros];
+ [self setPublications:pubs];
- if (pubs || [self publications])
- [self setPublications:pubs];
- else
- // don't use setPublications: on authentication failure or cancel, as
it will immediately get the publications again
- [self notifyUpdate];
-
[self didChangeValueForKey:@"icon"];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
