Revision: 27975
          http://sourceforge.net/p/bibdesk/svn/27975
Author:   hofman
Date:     2022-09-30 23:16:15 +0000 (Fri, 30 Sep 2022)
Log Message:
-----------
return failure when not writing a search group and no pubs

Modified Paths:
--------------
    trunk/bibdesk/BibDocument_DataSource.m

Modified: trunk/bibdesk/BibDocument_DataSource.m
===================================================================
--- trunk/bibdesk/BibDocument_DataSource.m      2022-09-30 22:54:39 UTC (rev 
27974)
+++ trunk/bibdesk/BibDocument_DataSource.m      2022-09-30 23:16:15 UTC (rev 
27975)
@@ -1135,18 +1135,19 @@
     
     if (success && searchGroup) {
         Class providerClass = NSClassFromString(@"NSFilePromiseProvider");
+        id item = nil;
         if (providerClass) {
-            id item = [[[providerClass alloc] 
initWithFileType:@"net.sourceforge.bibdesk.bdsksearch" delegate:searchGroup] 
autorelease];
+            item = [[[providerClass alloc] 
initWithFileType:@"net.sourceforge.bibdesk.bdsksearch" delegate:searchGroup] 
autorelease];
             if (([NSEvent standardModifierFlags] & NSAlternateKeyMask) != 0)
                 [item setUserInfo:@"BDSKIncludePassword"];
-            [pboard writeObjects:[NSArray arrayWithObjects:item, nil]];
         } else {
-            NSPasteboardItem *item = [[[NSPasteboardItem alloc] init] 
autorelease];
+            item = [[[NSPasteboardItem alloc] init] autorelease];
             [item setDataProvider:searchGroup forTypes:[NSArray 
arrayWithObjects:(NSString *)kPasteboardTypeFileURLPromise, (NSString 
*)kPasteboardTypeFilePromiseContent, nil]];
             if (([NSEvent standardModifierFlags] & NSAlternateKeyMask) != 0)
                 [item setPropertyList:[NSNumber numberWithBool:YES] 
forType:@"net.sourceforge.bibdesk.bdsksearch.includepassword"];
-            [pboard writeObjects:[NSArray arrayWithObjects:item, nil]];
         }
+        if (nil == item || NO == [pboard writeObjects:[NSArray 
arrayWithObjects:item, nil]])
+            success = [pubs count] > 0;
     }
     
     return success;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to