Revision: 28400
http://sourceforge.net/p/bibdesk/svn/28400
Author: hofman
Date: 2023-10-10 15:27:30 +0000 (Tue, 10 Oct 2023)
Log Message:
-----------
destroy completionHandler block when being done, to break any possible retain
cycles if the controller would be used inside the block
Modified Paths:
--------------
trunk/bibdesk/BDSKMergeController.m
Modified: trunk/bibdesk/BDSKMergeController.m
===================================================================
--- trunk/bibdesk/BDSKMergeController.m 2023-10-06 14:41:14 UTC (rev 28399)
+++ trunk/bibdesk/BDSKMergeController.m 2023-10-10 15:27:30 UTC (rev 28400)
@@ -160,6 +160,7 @@
[self merge];
} else if (completionHandler) {
completionHandler(NO, BDSKAutoGeneratedNone);
+ BDSKBLOCKDESTROY(completionHandler);
}
[super dismiss:sender];
}
@@ -403,6 +404,7 @@
completionHandler(NO, BDSKAutoGeneratedNone);
NSBeep();
}
+ BDSKBLOCKDESTROY(completionHandler);
}
- (void)mergeOverwriting {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
