Revision: 28557
http://sourceforge.net/p/bibdesk/svn/28557
Author: hofman
Date: 2024-01-05 23:20:24 +0000 (Fri, 05 Jan 2024)
Log Message:
-----------
remove unused method for bug that should be resolved by now
Modified Paths:
--------------
trunk/bibdesk/BDSKURLGroup.m
trunk/bibdesk/BibDocument.m
Modified: trunk/bibdesk/BDSKURLGroup.m
===================================================================
--- trunk/bibdesk/BDSKURLGroup.m 2024-01-05 20:01:54 UTC (rev 28556)
+++ trunk/bibdesk/BDSKURLGroup.m 2024-01-05 23:20:24 UTC (rev 28557)
@@ -120,16 +120,14 @@
return [[[self class] alloc] initWithName:name URL:URL];
}
-- (void)cleanup {
- [self stopRetrieving];
- if ([URL isFileURL] == NO && fileURL)
- [[NSFileManager defaultManager] removeItemAtURL:fileURL error:NULL];
-}
-
- (void)dealloc;
{
// should always be on the main thread, see BibDocument, but be sure
- BDSKENSURE_MAIN_THREAD( [self cleanup]; );
+ BDSKENSURE_MAIN_THREAD(
+ [self stopRetrieving];
+ if ([URL isFileURL] == NO && fileURL)
+ [[NSFileManager defaultManager] removeItemAtURL:fileURL
error:NULL];
+ );
BDSKDESTROY(URL);
BDSKDESTROY(fileURL);
[super dealloc];
Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m 2024-01-05 20:01:54 UTC (rev 28556)
+++ trunk/bibdesk/BibDocument.m 2024-01-05 23:20:24 UTC (rev 28557)
@@ -267,16 +267,6 @@
- (void)encodeWithCoder:(NSCoder *)encoder {}
-- (void)invalidateSearchFieldCellTimer{
- // AppKit bug workarounds: NSSearchFieldCell's timer creates a retain
cycle after typing in it, so we manually invalidate it when the document is
deallocated to avoid leaking the cell and timer. Further, if the insertion
point is in the searchfield cell when the window closes, the field editor (and
associated text system) and undo manager also leak, so we send -[documentWindow
endEditingFor:nil] in windowWillClose:.
- id timer = [[searchField cell] valueForKey:@"_partialStringTimer"];
- if (timer && [timer respondsToSelector:@selector(invalidate)]) {
- [timer invalidate];
- [[searchField cell] setValue:nil forKey:@"_partialStringTimer"];
- }
- [searchField setCell:nil];
-}
-
- (void)dealloc{
[[NSNotificationCenter defaultCenter] removeObserver:self];
[[NSDistributedNotificationCenter defaultCenter] removeObserver:self];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
