Revision: 29421
http://sourceforge.net/p/bibdesk/svn/29421
Author: hofman
Date: 2025-08-08 14:14:38 +0000 (Fri, 08 Aug 2025)
Log Message:
-----------
only download favicon for webb group webview
Modified Paths:
--------------
trunk/bibdesk/BDSKWebGroup.m
trunk/bibdesk/BDSKWebView.h
trunk/bibdesk/BDSKWebView.m
Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m 2025-08-08 09:38:39 UTC (rev 29420)
+++ trunk/bibdesk/BDSKWebGroup.m 2025-08-08 14:14:38 UTC (rev 29421)
@@ -164,6 +164,7 @@
if (webView == nil) {
webView = [[BDSKWebView alloc] init];
[webView setDelegate:self];
+ [webView setWantsFavicon:YES];
[webView setHostWindow:[[[document windowControllers] firstObject]
window]];
}
return webView;
Modified: trunk/bibdesk/BDSKWebView.h
===================================================================
--- trunk/bibdesk/BDSKWebView.h 2025-08-08 09:38:39 UTC (rev 29420)
+++ trunk/bibdesk/BDSKWebView.h 2025-08-08 14:14:38 UTC (rev 29421)
@@ -59,6 +59,7 @@
NSURLSessionTask *faviconDownload;
NSImage *favicon;
BOOL faviconFromOrigin;
+ BOOL wantsFavicon;
NSTimer *urlTimer;
}
@@ -66,6 +67,7 @@
@property (nonatomic, nullable, weak) id<BDSKWebViewNavigationDelegate>
navigationDelegate;
@property (nonatomic, nullable, strong) NSURL *URL;
+@property (nonatomic) BOOL wantsFavicon;
- (IBAction)addBookmark:(nullable id)sender;
- (IBAction)saveSource:(nullable id)sender;
Modified: trunk/bibdesk/BDSKWebView.m
===================================================================
--- trunk/bibdesk/BDSKWebView.m 2025-08-08 09:38:39 UTC (rev 29420)
+++ trunk/bibdesk/BDSKWebView.m 2025-08-08 14:14:38 UTC (rev 29421)
@@ -84,6 +84,7 @@
@implementation BDSKWebView
+@synthesize wantsFavicon;
@dynamic delegate, navigationDelegate, URL;
- (instancetype)initWithFrame:(NSRect)frameRect frameName:(NSString
*)frameName groupName:(NSString *)groupName {
@@ -449,7 +450,7 @@
}
}
}
- if ([sender respondsToSelector:@selector(retrieveFavicon)])
+ if ([sender respondsToSelector:@selector(retrieveFavicon)] &&
[(BDSKWebView *)sender wantsFavicon])
[(BDSKWebView *)sender retrieveFavicon];
else
[self webView:sender setIcon:[sender mainFrameIcon]];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
