Revision: 29467
http://sourceforge.net/p/bibdesk/svn/29467
Author: hofman
Date: 2025-08-25 14:43:43 +0000 (Mon, 25 Aug 2025)
Log Message:
-----------
alwqys fetch faviocn in legacy webview
Modified Paths:
--------------
trunk/bibdesk/BDSKTextImportController.m
trunk/bibdesk/BDSKWebGroup.m
trunk/bibdesk/BDSKWebView.h
trunk/bibdesk/BDSKWebView.m
trunk/bibdesk/de.lproj/Localizable.strings
trunk/bibdesk/en.lproj/Localizable.strings
trunk/bibdesk/fr.lproj/Localizable.strings
Modified: trunk/bibdesk/BDSKTextImportController.m
===================================================================
--- trunk/bibdesk/BDSKTextImportController.m 2025-08-25 14:04:54 UTC (rev
29466)
+++ trunk/bibdesk/BDSKTextImportController.m 2025-08-25 14:43:43 UTC (rev
29467)
@@ -587,7 +587,7 @@
}
- (void)setTemporaryTypeSelectStatusMessage:(BOOL)shouldSet {
- NSString *message = NSLocalizedString(@"Press \u2318= to select a field.",
@"Status message");
+ NSString *message = NSLocalizedString(@"Press \u2318= to select a field to
set the selection in.", @"Status message");
if (shouldSet)
[statusLine setStringValue:message];
else if ([[statusLine stringValue] isEqualToString:message])
Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m 2025-08-25 14:04:54 UTC (rev 29466)
+++ trunk/bibdesk/BDSKWebGroup.m 2025-08-25 14:43:43 UTC (rev 29467)
@@ -164,7 +164,6 @@
if (webView == nil) {
webView = [[BDSKWebView alloc] init];
[webView setDelegate:self];
- [webView setWantsFavicon:YES];
[webView setHostWindow:[[[document windowControllers] firstObject]
window]];
}
return webView;
Modified: trunk/bibdesk/BDSKWebView.h
===================================================================
--- trunk/bibdesk/BDSKWebView.h 2025-08-25 14:04:54 UTC (rev 29466)
+++ trunk/bibdesk/BDSKWebView.h 2025-08-25 14:43:43 UTC (rev 29467)
@@ -59,7 +59,6 @@
NSURLSessionTask *faviconDownload;
NSImage *favicon;
BOOL faviconFromOrigin;
- BOOL wantsFavicon;
NSTimer *urlTimer;
}
@@ -67,7 +66,6 @@
@property (nonatomic, nullable, weak) id<BDSKWebViewNavigationDelegate>
navigationDelegate;
@property (nonatomic, nullable, strong) NSURL *URL;
-@property (nonatomic) BOOL wantsFavicon;
- (IBAction)addBookmark:(nullable id)sender;
- (IBAction)saveSource:(nullable id)sender;
Modified: trunk/bibdesk/BDSKWebView.m
===================================================================
--- trunk/bibdesk/BDSKWebView.m 2025-08-25 14:04:54 UTC (rev 29466)
+++ trunk/bibdesk/BDSKWebView.m 2025-08-25 14:43:43 UTC (rev 29467)
@@ -84,7 +84,6 @@
@implementation BDSKWebView
-@synthesize wantsFavicon;
@dynamic delegate, navigationDelegate, URL;
- (instancetype)initWithFrame:(NSRect)frameRect frameName:(NSString
*)frameName groupName:(NSString *)groupName {
@@ -414,7 +413,7 @@
if (frame == [sender mainFrame]) {
if ([sender respondsToSelector:@selector(stopMonitoringURL)])
[(BDSKWebView *)sender stopMonitoringURL];
- if ([sender respondsToSelector:@selector(resetFavicon)] &&
[(BDSKWebView *)sender wantsFavicon])
+ if ([sender respondsToSelector:@selector(resetFavicon)])
[(BDSKWebView *)sender resetFavicon];
else
[self webView:sender setIcon:nil];
@@ -450,7 +449,7 @@
}
}
}
- if ([sender respondsToSelector:@selector(retrieveFavicon)] &&
[(BDSKWebView *)sender wantsFavicon])
+ if ([sender respondsToSelector:@selector(retrieveFavicon)])
[(BDSKWebView *)sender retrieveFavicon];
else
[self webView:sender setIcon:[sender mainFrameIcon]];
Modified: trunk/bibdesk/de.lproj/Localizable.strings
===================================================================
(Binary files differ)
Modified: trunk/bibdesk/en.lproj/Localizable.strings
===================================================================
(Binary files differ)
Modified: trunk/bibdesk/fr.lproj/Localizable.strings
===================================================================
(Binary files differ)
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
