Revision: 29668
http://sourceforge.net/p/bibdesk/svn/29668
Author: hofman
Date: 2025-10-05 14:37:28 +0000 (Sun, 05 Oct 2025)
Log Message:
-----------
implement initWithWindow: as convenience initializer in some controller classes
Modified Paths:
--------------
trunk/bibdesk/BDSKScriptGroupSheetController.h
trunk/bibdesk/BDSKScriptGroupSheetController.m
trunk/bibdesk/BDSKSearchGroupSheetController.h
trunk/bibdesk/BDSKSearchGroupSheetController.m
trunk/bibdesk/BDSKURLGroupSheetController.h
trunk/bibdesk/BDSKURLGroupSheetController.m
Modified: trunk/bibdesk/BDSKScriptGroupSheetController.h
===================================================================
--- trunk/bibdesk/BDSKScriptGroupSheetController.h 2025-10-05 14:25:31 UTC
(rev 29667)
+++ trunk/bibdesk/BDSKScriptGroupSheetController.h 2025-10-05 14:37:28 UTC
(rev 29668)
@@ -56,7 +56,6 @@
- (instancetype)initWithPath:(nullable NSString *)aPath arguments:(nullable
NSString *)anArguments NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithWindow:(nullable NSWindow *)window NS_UNAVAILABLE;
- (nullable instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@property (nonatomic, nullable, strong) IBOutlet BDSKDragTextField *pathField;
Modified: trunk/bibdesk/BDSKScriptGroupSheetController.m
===================================================================
--- trunk/bibdesk/BDSKScriptGroupSheetController.m 2025-10-05 14:25:31 UTC
(rev 29667)
+++ trunk/bibdesk/BDSKScriptGroupSheetController.m 2025-10-05 14:37:28 UTC
(rev 29668)
@@ -52,11 +52,6 @@
@synthesize pathField, objectController, okButton, cancelButton, path,
arguments;
@dynamic undoManager;
-- (instancetype)init {
- self = [self initWithPath:nil arguments:nil];
- return self;
-}
-
- (instancetype)initWithPath:(NSString *)aPath arguments:(NSString
*)anArguments {
self = [super initWithWindow:nil];
if (self) {
@@ -68,6 +63,10 @@
return self;
}
+- (instancetype)initWithWindow:(NSWindow *)window {
+ return [self initWithPath:nil arguments:nil];
+}
+
- (void)dealloc {
[pathField setDelegate:nil];
}
Modified: trunk/bibdesk/BDSKSearchGroupSheetController.h
===================================================================
--- trunk/bibdesk/BDSKSearchGroupSheetController.h 2025-10-05 14:25:31 UTC
(rev 29667)
+++ trunk/bibdesk/BDSKSearchGroupSheetController.h 2025-10-05 14:37:28 UTC
(rev 29668)
@@ -80,7 +80,6 @@
- (instancetype)initWithServerInfo:(nullable BDSKServerInfo *)aServerInfo
NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithWindow:(nullable NSWindow *)window NS_UNAVAILABLE;
- (nullable instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@property (nonatomic, nullable, strong) IBOutlet NSPopUpButton *serverPopup;
Modified: trunk/bibdesk/BDSKSearchGroupSheetController.m
===================================================================
--- trunk/bibdesk/BDSKSearchGroupSheetController.m 2025-10-05 14:25:31 UTC
(rev 29667)
+++ trunk/bibdesk/BDSKSearchGroupSheetController.m 2025-10-05 14:37:28 UTC
(rev 29668)
@@ -76,10 +76,6 @@
return keyPaths;
}
-- (instancetype)init {
- return [self initWithServerInfo:nil];
-}
-
- (instancetype)initWithServerInfo:(BDSKServerInfo *)aServerInfo {
self = [super initWithWindow:nil];
if (self) {
@@ -94,6 +90,10 @@
return self;
}
+- (instancetype)initWithWindow:(NSWindow *)window {
+ return [self initWithServerInfo:nil];
+}
+
- (NSString *)windowNibName { return @"BDSKSearchGroupSheet"; }
- (void)reloadServersSelectingServerNamed:(NSString *)name{
Modified: trunk/bibdesk/BDSKURLGroupSheetController.h
===================================================================
--- trunk/bibdesk/BDSKURLGroupSheetController.h 2025-10-05 14:25:31 UTC (rev
29667)
+++ trunk/bibdesk/BDSKURLGroupSheetController.h 2025-10-05 14:37:28 UTC (rev
29668)
@@ -56,7 +56,6 @@
- (instancetype)initWithURL:(nullable NSURL *)aURL NS_DESIGNATED_INITIALIZER;
-- (instancetype)initWithWindow:(nullable NSWindow *)window NS_UNAVAILABLE;
- (nullable instancetype)initWithCoder:(NSCoder *)coder NS_UNAVAILABLE;
@property (nonatomic, nullable, strong) IBOutlet BDSKDragTextField *urlField;
Modified: trunk/bibdesk/BDSKURLGroupSheetController.m
===================================================================
--- trunk/bibdesk/BDSKURLGroupSheetController.m 2025-10-05 14:25:31 UTC (rev
29667)
+++ trunk/bibdesk/BDSKURLGroupSheetController.m 2025-10-05 14:37:28 UTC (rev
29668)
@@ -55,11 +55,6 @@
@synthesize urlField, objectController, okButton, cancelButton, urlString;
@dynamic URL, undoManager;
-- (instancetype)init {
- self = [self initWithURL:nil];
- return self;
-}
-
- (instancetype)initWithURL:(NSURL *)aURL {
self = [super initWithWindow:nil];
if (self) {
@@ -70,6 +65,10 @@
return self;
}
+- (instancetype)initWithWindow:(NSWindow *)windo {
+ return[self initWithURL:nil];
+}
+
- (void)dealloc {
[urlField setDelegate:nil];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
