Revision: 29696
          http://sourceforge.net/p/bibdesk/svn/29696
Author:   hofman
Date:     2025-10-10 16:05:17 +0000 (Fri, 10 Oct 2025)
Log Message:
-----------
message client object from one point

Modified Paths:
--------------
    trunk/bibdesk/BDSKSharingClient.m

Modified: trunk/bibdesk/BDSKSharingClient.m
===================================================================
--- trunk/bibdesk/BDSKSharingClient.m   2025-10-10 15:54:05 UTC (rev 29695)
+++ trunk/bibdesk/BDSKSharingClient.m   2025-10-10 16:05:17 UTC (rev 29696)
@@ -465,8 +465,8 @@
     
     @autoreleasepool {
         
+        NSDictionary *archive = nil;
         @try {
-            NSDictionary *archive = nil;
             NSData *proxyData = [[self remoteServer] 
archivedSnapshotOfPublications];
             
             if([proxyData length] != 0){
@@ -479,23 +479,19 @@
                     @throw errorStr;
                 }
             }
-            // use the main thread; this avoids an extra (un)archiving between 
threads and it ends up posting notifications for UI updates
-            dispatch_sync(dispatch_get_main_queue(), ^{
-                [client setArchivedPublicationsAndMacros:archive];
-            });
-            // the client will reset the isRetriving flag when the data is set
         }
         @catch(id exception){
             NSLog(@"%@: discarding exception \"%@\" while retrieving 
publications", [self class], exception);
             atomic_store(&failedDownload, YES);
             [self setErrorMessage:NSLocalizedString(@"Failed to retrieve 
publications", @"")];
-            
-            // this posts a notification that the publications of the client 
changed, forcing a redisplay of the table cell
-            dispatch_async(dispatch_get_main_queue(), ^{
-                [client setArchivedPublicationsAndMacros:nil];
-            });
-            // the client will reset the isRetriving flag when the data is set
+            archive = nil;
         }
+        // use the main thread; this avoids an extra (un)archiving between 
threads and it ends up posting notifications for UI updates
+        // this posts a notification that the publications of the client 
changed, forcing a redisplay of the table cell
+        dispatch_sync(dispatch_get_main_queue(), ^{
+            [client setArchivedPublicationsAndMacros:archive];
+        });
+        // the client will reset the isRetriving flag when the data is set
     }
 }
 

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to