Revision: 29726
http://sourceforge.net/p/bibdesk/svn/29726
Author: hofman
Date: 2025-10-14 15:53:46 +0000 (Tue, 14 Oct 2025)
Log Message:
-----------
declare name as NSString in accessors and initializers in most group classes
Modified Paths:
--------------
trunk/bibdesk/BDSKExternalGroup.h
trunk/bibdesk/BDSKExternalGroup.m
trunk/bibdesk/BDSKGroup.h
trunk/bibdesk/BDSKGroup.m
trunk/bibdesk/BDSKParentGroup.h
trunk/bibdesk/BDSKParentGroup.m
trunk/bibdesk/BDSKSmartGroup.h
trunk/bibdesk/BDSKStaticGroup.h
Modified: trunk/bibdesk/BDSKExternalGroup.h
===================================================================
--- trunk/bibdesk/BDSKExternalGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKExternalGroup.h 2025-10-14 15:53:46 UTC (rev 29726)
@@ -51,6 +51,11 @@
BDSKMacroResolver *macroResolver;
}
+- (instancetype)initWithName:(NSString *)aName NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithCoder:(NSCoder *)decoder NS_DESIGNATED_INITIALIZER;
+
+@property (nonatomic, readonly) NSString *name;
+
- (void)refresh;
- (void)wantsPublicationsImmediately:(BOOL)immediate;
Modified: trunk/bibdesk/BDSKExternalGroup.m
===================================================================
--- trunk/bibdesk/BDSKExternalGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKExternalGroup.m 2025-10-14 15:53:46 UTC (rev 29726)
@@ -49,7 +49,7 @@
@implementation BDSKExternalGroup
-@dynamic shouldRetrievePublications;
+@dynamic shouldRetrievePublications, name;
// designated initializer
- (instancetype)initWithName:(NSString *)aName {
@@ -210,7 +210,7 @@
@synthesize errorMessage;
-- (void)setName:(id)newName {
+- (void)setName:(NSString *)newName {
if (name != newName) {
[(BDSKMutableExternalGroup *)[[self undoManager]
prepareWithInvocationTarget:self] setName:name];
name = newName;
Modified: trunk/bibdesk/BDSKGroup.h
===================================================================
--- trunk/bibdesk/BDSKGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKGroup.h 2025-10-14 15:53:46 UTC (rev 29726)
@@ -124,7 +124,7 @@
@protocol BDSKMutableGroup <NSObject>
-@property (nonatomic, strong) id name;
+@property (nonatomic, strong) NSString *name;
@property (nonatomic, nullable, readonly) NSUndoManager *undoManager;
@end
Modified: trunk/bibdesk/BDSKGroup.m
===================================================================
--- trunk/bibdesk/BDSKGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKGroup.m 2025-10-14 15:53:46 UTC (rev 29726)
@@ -166,7 +166,7 @@
@implementation BDSKMutableGroup
-- (void)setName:(id)newName {
+- (void)setName:(NSString *)newName {
if (name != newName) {
[(BDSKMutableGroup *)[[self undoManager]
prepareWithInvocationTarget:self] setName:name];
name = newName;
Modified: trunk/bibdesk/BDSKParentGroup.h
===================================================================
--- trunk/bibdesk/BDSKParentGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKParentGroup.h 2025-10-14 15:53:46 UTC (rev 29726)
@@ -48,6 +48,11 @@
NSArray *sortDescriptors;
}
+- (instancetype)initWithName:(NSString *)aName NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithCoder:(NSCoder *)coderr NS_DESIGNATED_INITIALIZER;
+
+@property (nonatomic, readonly) NSString *name;
+
@property (nonatomic, readonly) NSString *identifier;
- (NSUInteger)numberOfChildren;
Modified: trunk/bibdesk/BDSKParentGroup.m
===================================================================
--- trunk/bibdesk/BDSKParentGroup.m 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKParentGroup.m 2025-10-14 15:53:46 UTC (rev 29726)
@@ -54,7 +54,7 @@
@implementation BDSKParentGroup
-@dynamic identifier;
+@dynamic identifier, name;
- (instancetype)initWithName:(NSString *)aName {
self = [super initWithName:aName];
Modified: trunk/bibdesk/BDSKSmartGroup.h
===================================================================
--- trunk/bibdesk/BDSKSmartGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKSmartGroup.h 2025-10-14 15:53:46 UTC (rev 29726)
@@ -54,6 +54,7 @@
- (instancetype)initWithFilter:(BDSKFilter *)aFilter;
- (instancetype)initWithName:(NSString *)aName filter:(BDSKFilter *)aFilter
NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithName:(NSString *)aName;
- (instancetype)initWithCoder:(NSCoder *)coder NS_DESIGNATED_INITIALIZER;
@property (nonatomic, strong) BDSKFilter *filter;
Modified: trunk/bibdesk/BDSKStaticGroup.h
===================================================================
--- trunk/bibdesk/BDSKStaticGroup.h 2025-10-14 09:29:04 UTC (rev 29725)
+++ trunk/bibdesk/BDSKStaticGroup.h 2025-10-14 15:53:46 UTC (rev 29726)
@@ -49,7 +49,7 @@
}
- (instancetype)initWithName:(NSString *)aName publications:(nullable NSArray
*)array NS_DESIGNATED_INITIALIZER;
-
+- (instancetype)initWithName:(NSString *)aName;
- (instancetype)initWithCoder:(NSCoder *)decoder NS_DESIGNATED_INITIALIZER;
@property (nonatomic, copy) NSArray *publications;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
