Revision: 29729
http://sourceforge.net/p/bibdesk/svn/29729
Author: hofman
Date: 2025-10-16 14:09:30 +0000 (Thu, 16 Oct 2025)
Log Message:
-----------
make sure input for wb parser is nonnull, return value is alwways nonnull
Modified Paths:
--------------
trunk/bibdesk/BDSKWebGroup.m
trunk/bibdesk/BDSKWebParser.h
trunk/bibdesk/BDSKWebParser.m
Modified: trunk/bibdesk/BDSKWebGroup.m
===================================================================
--- trunk/bibdesk/BDSKWebGroup.m 2025-10-14 16:22:56 UTC (rev 29728)
+++ trunk/bibdesk/BDSKWebGroup.m 2025-10-16 14:09:30 UTC (rev 29729)
@@ -246,7 +246,7 @@
DOMDocument *domDocument = [frame DOMDocument];
BOOL shouldMonitorURL = NO;
- BDSKWebParser *parser = [BDSKWebParser parserForDocument:domDocument
fromURL:url shouldMonitor:&shouldMonitorURL];
+ BDSKWebParser *parser = url == nil || domDocument == nil ? nil :
[BDSKWebParser parserForDocument:domDocument fromURL:url
shouldMonitor:&shouldMonitorURL];
if (parser) {
Modified: trunk/bibdesk/BDSKWebParser.h
===================================================================
--- trunk/bibdesk/BDSKWebParser.h 2025-10-14 16:22:56 UTC (rev 29728)
+++ trunk/bibdesk/BDSKWebParser.h 2025-10-16 14:09:30 UTC (rev 29729)
@@ -78,7 +78,7 @@
// set at the end of -start, to know thereis not more coming, so we may finish
@property (nonatomic) BOOL finishedStarting;
-- (nullable instancetype)initWithDocument:(DOMDocument *)aDomDocument
fromURL:(NSURL *)aURL NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithDocument:(DOMDocument *)aDomDocument fromURL:(NSURL
*)aURL NS_DESIGNATED_INITIALIZER;
- (instancetype)init NS_UNAVAILABLE;
- (void)startWithDelegate:(id<BDSKWebParserDelegate>)aDelegate;
Modified: trunk/bibdesk/BDSKWebParser.m
===================================================================
--- trunk/bibdesk/BDSKWebParser.m 2025-10-14 16:22:56 UTC (rev 29728)
+++ trunk/bibdesk/BDSKWebParser.m 2025-10-16 14:09:30 UTC (rev 29729)
@@ -167,10 +167,6 @@
}
- (instancetype)initWithDocument:(DOMDocument *)aDomDocument fromURL:(NSURL
*)aURL {
- if (aDomDocument == nil || aURL == nil) {
- self = nil;
- return nil;
- }
self = [super init];
if (self) {
domDocument = aDomDocument;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
