With the Tiger implementation (i.e. not calling trackMouse ourselves), is the button not working at all, or just not highlighting? If the latter, would it help to remove the - setButtonHighlighted: in willDisplayCell:?
Christiaan On 10 Dec 2007, at 9:02 PM, [EMAIL PROTECTED] wrote: > Revision: 11838 > http://bibdesk.svn.sourceforge.net/bibdesk/? > rev=11838&view=rev > Author: amaxwell > Date: 2007-12-10 12:02:20 -0800 (Mon, 10 Dec 2007) > > Log Message: > ----------- > workarounds and comments for 10.5 to partially fix some problems > > Modified Paths: > -------------- > trunk/bibdesk/BibEditor.m > > Modified: trunk/bibdesk/BibEditor.m > =================================================================== > --- trunk/bibdesk/BibEditor.m 2007-12-10 19:34:08 UTC (rev 11837) > +++ trunk/bibdesk/BibEditor.m 2007-12-10 20:02:20 UTC (rev 11838) > @@ -3291,10 +3291,14 @@ > NSRect buttonRect = [self buttonRectForBounds:cellFrame]; > NSPoint mouseLoc = [controlView convertPoint:[theEvent > locationInWindow] fromView:nil]; > if (NSMouseInRect(mouseLoc, buttonRect, [controlView > isFlipped])) { > + // @@ button isn't highlighted on 10.5; sending > displayIfNeeded breaks the button action if called before hadButton > is set, and it doesn't help anyway > [self setButtonHighlighted:YES]; > BOOL keepOn = YES; > BOOL isInside = YES; > + // @@ workaround for 10.5 > + BOOL hadButton = hasButton; > while (keepOn) { > + // @@ on 10.5 hasButton ivar is NO after this call > theEvent = [[controlView window] nextEventMatchingMask: > > NSLeftMouseUpMask | NSLeftMouseDraggedMask]; > mouseLoc = [controlView convertPoint:[theEvent > locationInWindow] fromView:nil]; > isInside = NSMouseInRect(mouseLoc, buttonRect, > [controlView > isFlipped]); > @@ -3303,7 +3307,7 @@ > [self setButtonHighlighted:isInside]; > break; > case NSLeftMouseUp: > - if (isInside && hasButton) > + if (isInside && hadButton) > [(NSControl *)controlView > sendAction:buttonAction to:buttonTarget]; > [self setButtonHighlighted:NO]; > keepOn = NO; > > > This was sent by the SourceForge.net collaborative development > platform, the world's largest Open Source development site. > > ---------------------------------------------------------------------- > --- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Bibdesk-commit mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/bibdesk-commit ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
