On Jan 8, 2008, at 2:49 AM, Christiaan Hofman wrote: > Does the OBASSERT fail in BDSKMacroEditor?
Yes, right before the exception. > Could it perhaps be that Leopard uses a copy of the cell or > formatter for editing? That would be pretty bad for our complex > string editing, because we need access to the actual editing cell, > and that's a private ivar. It could be that it uses a copy of the cell (or some cell), but I checked copyWithZone: and the new preparedCell... method and they seem to have the correct formatter at copy time. > > > Christiaan > > On Jan 8, 2008 11:34 AM, Christiaan Hofman <[EMAIL PROTECTED]> wrote: > It can't be the cell. The only override that kicks in without a > button is setting the background color for the field editor. > > Which field has a citation field, does it make a difference which one > you're editing? No. It happens randomly, and sometimes takes a few tries to reproduce it. It smells like a garbage pointer. > And does it also happen in the text import sheet? Haven't tried that yet. > > > Christiaan > > On 8 Jan 2008, at 3:31 AM, Adam R. Maxwell wrote: > > > In fact, even if I comment out the entire tableview subclass > > implementation, it still has this problem. Maybe something with > > the cell? > > > > On Monday, January 07, 2008, at 06:11PM, "Adam R. Maxwell" > > <[EMAIL PROTECTED]> wrote: > >> It still happens. Even if I override > >> editColumn:row:withEvent:select: and call the delegate there, the > >> cell has the correct formatter before calling super and then it > >> craps out as soon as I enter a character. I'm assuming this works > >> on Tiger, then? I click in the cell with the mouse, use cmd-a to > >> select text, then press a character key to get the exception. > >> > >> On Monday, January 07, 2008, at 05:58PM, "Christiaan Hofman" > >> <[EMAIL PROTECTED]> wrote: > >>> Try my solution. I think it is due to our editing overrides. > Perhaps > >>> it should also be done just before editing in mouseDown. Does it > >>> happen after tab, or also after moving by mouseDown? > >>> > >>> Christiaan > >>> > >>> On 8 Jan 2008, at 2:38 AM, Adam R. Maxwell wrote: > >>> > >>>> Okay, so I thought this was fixed but it's just failing less > >>>> frequently. Any other ideas here? The cell with the string > value > >>>> I'm editing has a complex string formatter in copyWithZone:, so > >>>> that's working okay. Is there something going on with the field > >>>> editor? > >>>> > >>>> On Monday, January 07, 2008, at 05:22PM, > >>>> <[EMAIL PROTECTED]> wrote: > >>>>> Revision: 12349 > >>>>> http://bibdesk.svn.sourceforge.net/bibdesk/? > >>>>> rev=12349&view=rev > >>>>> Author: amaxwell > >>>>> Date: 2008-01-07 17:22:40 -0800 (Mon, 07 Jan 2008) > >>>>> > >>>>> Log Message: > >>>>> ----------- > >>>>> Fix macro editing exception in editor. > >>>>> > >>>>> Modified Paths: > >>>>> -------------- > >>>>> trunk/bibdesk/BDSKEditor.m > >>>>> > >>>>> Modified: trunk/bibdesk/BDSKEditor.m > >>>>> > ================================================================== > >>>>> = > >>>>> --- trunk/bibdesk/BDSKEditor.m 2008-01-08 00:26:19 UTC (rev > 12348) > >>>>> +++ trunk/bibdesk/BDSKEditor.m 2008-01-08 01:22:40 UTC (rev > 12349) > >>>>> @@ -2710,6 +2710,10 @@ > >>>>> > >>>>> - (BOOL)tableView:(NSTableView *)tv shouldEditTableColumn: > >>>>> (NSTableColumn *)tableColumn row:(int)row{ > >>>>> if ([tv isEqual:tableView]) { > >>>>> + > >>>>> + // @@ Workaround for a macro editing bug when > converting > >>>>> a string to a number (hit cmd-r, delete braces, start entering > >>>>> text). This caused an exception since the cell's formatter > was a > >>>>> BDSKCitationFormatter and it ended up being sent parseError:. > It > >>>>> looks like tableView:willDisplayCell:... is too late, at least > on > >>>>> Leopard, so maybe the formatter could be set here regardless? > >>>>> + [self tableView:tv willDisplayCell:[tableColumn > >>>>> dataCellForRow:row] forTableColumn:tableColumn row:row]; > >>>>> + > >>>>> ignoreEdit = NO; > >>>>> // we always want to "edit" even when we are not > editable, > >>>>> so we can always select, and the cell will prevent editing when > >>>>> isEditable == NO > >>>>> if ([[tableColumn identifier] isEqualToString:@"value"]) > >>>>> > >>>>> > >>>>> This was sent by the SourceForge.net collaborative development > >>>>> platform, the world's largest Open Source development site. > >>>>> > >>>>> > ------------------------------------------------------------------ > >>>>> --- > >>>>> ---- > >>>>> Check out the new SourceForge.net Marketplace. > >>>>> It's the best place to buy or sell services for > >>>>> just about anything Open Source. > >>>>> http://ad.doubleclick.net/clk;164216239;13503038;w?http:// > sf.net/ > >>>>> marketplace > >>>>> _______________________________________________ > >>>>> Bibdesk-commit mailing list > >>>>> [EMAIL PROTECTED] > >>>>> https://lists.sourceforge.net/lists/listinfo/bibdesk-commit > >>>>> > >>>>> > >>>> > >>>> > ------------------------------------------------------------------- > >>>> --- > >>>> --- > >>>> Check out the new SourceForge.net Marketplace. > >>>> It's the best place to buy or sell services for > >>>> just about anything Open Source. > >>>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > >>>> marketplace > >>>> _______________________________________________ > >>>> Bibdesk-develop mailing list > >>>> Bibdesk-develop@lists.sourceforge.net > >>>> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > >>> > >>> > >>> > -------------------------------------------------------------------- > >>> ----- > >>> Check out the new SourceForge.net Marketplace. > >>> It's the best place to buy or sell services for > >>> just about anything Open Source. > >>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > >>> marketplace > >>> _______________________________________________ > >>> Bibdesk-develop mailing list > >>> Bibdesk-develop@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > >>> > >>> > >> > >> > --------------------------------------------------------------------- > >> ---- > >> Check out the new SourceForge.net Marketplace. > >> It's the best place to buy or sell services for > >> just about anything Open Source. > >> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > >> marketplace > >> _______________________________________________ > >> Bibdesk-develop mailing list > >> Bibdesk-develop@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > >> > >> > > > > > ---------------------------------------------------------------------- > > --- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/ > > marketplace > > _______________________________________________ > > Bibdesk-develop mailing list > > Bibdesk-develop@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace_______________________________________________ > Bibdesk-develop mailing list > Bibdesk-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
