[ 
https://issues.apache.org/jira/browse/BIGTOP-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249898#comment-13249898
 ] 

Ron Bogdanoff commented on BIGTOP-509:
--------------------------------------

Hi Roman,

I thought about putting code up in the # Download part of package.mk as well.  
The reason I put the code further down in package.mk where I test 
$(2)_DOWNLOAD_URL and replace its value if necessary, is DOWNLOAD_URL is also 
used in # Helper targets, specifically in $(1)-info:  - if I replace the value 
of $(2)_DOWNLOAD_URL, and you do a make info, the " Will download from URL: 
$$($(2)_DOWNLOAD_URL) " will display the true URL where the tar will really be 
downloaded from.  If I had changed just the #Download part of package.mk, the 
info target will report the incorrect download URL in the event we need to get 
the tar from ARCHIVE.

True, there is an extra head only http request, but I thought it was a small 
price to pay to make $(2)_DOWNLOAD_URL contain the real url we will download 
from so other part of the code can still reference it and get the correct value.

In any event, please let me know which you prefer I can make the change you 
suggest if you like

Regards
Ron
                
> make all is failing because flume-1.0.0-incubating.tar.gz does not exist in 
> APACHE_MIRROR
> -----------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-509
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-509
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.3.0
>         Environment: all
>            Reporter: Ron Bogdanoff
>            Assignee: Ron Bogdanoff
>              Labels: patch
>             Fix For: 0.3.0
>
>         Attachments: BIGTOP-509.patch.diff
>
>
> bigtop.mk is attempting to download 
> http://apache.osuosl.org/flume/flume-1.0.0-incubating//flume-1.0.0-incubating.tar.gz
> However, it looks like flume-1.0.0 has been removed from the mirror site.  
> Instead there is 
> http://apache.osuosl.org/flume/flume-1.1.0-incubating//flume-1.1.0-incubating.tar.gz
> I have not submitted a patch as flume-1.1.0 has not been certified/tested on 
> bigtop-0.3.0.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to