[ 
https://issues.apache.org/jira/browse/BIGTOP-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291423#comment-13291423
 ] 

Roman Shaposhnik commented on BIGTOP-596:
-----------------------------------------

I guess my only concern is that configured then feels redundant. Basically does 
the presence/absence of the configuration block serve the same purpose as the 
configured property? IOW configured==true IFF configuration property is 
defined. Or am I missing something?

Finally, as a small nitpick, I'd recommend the following schema for the file 
property inside of a configuration block: 
{noformat}
<config type="xml-file" name="/etc/hadoop/conf/hdfs-site.xml">
   <property>
      <name>dfs.safemode.min.datanodes</name>
      <value>1</value>
   </property>

   <property>
      <name>dfs.safemode.extension</name>
      <value>0</value>
   </property>
</config>
{noformat}

Makes sense?
                
> add initialization for 'hadoop-hdfs-namenode' 'zookeeper-server' and 
> 'hbase-regionserver' daemons in package service test
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-596
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-596
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.4.0
>            Reporter: Johnny Zhang
>            Assignee: Johnny Zhang
>         Attachments: BIGTOP_596.txt
>
>
> the current package test doesn't format namenode, so that 
> hadoop-hdfs-namenode daemon cannot be started

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to