[
https://issues.apache.org/jira/browse/BIGTOP-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291887#comment-13291887
]
Roman Shaposhnik commented on BIGTOP-621:
-----------------------------------------
A couple more comments:
# "private static final String USERNAME = sh.exec("whoami").getOut().get(0);"
-- nor reason to do this since System.getProperty( "user.name" ) would do just
fine
# "+ execute("cat $HADOOP_CONF_DIR/core-site.xml");" -- I would suggest
parsing it with either Groovy XML slurper or better yet native Hadoop
Configuration class
# "execute("hadoop fs -test -e testDistcpInputs");" -- I would suggest
randomizing the naming of test directories/files
> Add test for distcp - intra cluster
> -----------------------------------
>
> Key: BIGTOP-621
> URL: https://issues.apache.org/jira/browse/BIGTOP-621
> Project: Bigtop
> Issue Type: Test
> Affects Versions: 0.4.0
> Reporter: Sujay Rau
> Fix For: 0.4.0
>
>
> Wrote a test that checks whether the distcp command and its suboptions (using
> a source file etc.) work without error and confirms expected output is
> correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
