[
https://issues.apache.org/jira/browse/BIGTOP-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393680#comment-13393680
]
Bruno Mahé edited comment on BIGTOP-527 at 6/18/12 6:53 PM:
------------------------------------------------------------
Great patch! Thanks a lot Roman.
But I see some issues as blockers. So here is a -1 since Peter put a +1.
Blocker issues:
* It does not build on anything else than Fedora. (although it looks like some
missing dependencies on the slaves)
* {noformat}+Conflicts: cloudera-desktop{noformat} should be killed
* I don't see any notify/subscribe in the hue puppet module (kind of a blocker,
but not really)
* bigtop-deploy/puppet/modules/hue/templates/hue.in does not have any Apache
license header
* In bigtop-packages/src/common/hue/install_hue.sh, I am pretty sure
{noformat}CONF_DIR=${CONF_DIR:-/etc/hue}{noformat} should be
{noformat}CONF_DIR=${CONF_DIR:-/etc/hue/conf}{noformat}
The most important one would be to see some green builds on jenkins.
Nice to have issues (can be dealt with separately):
* There are some missing dependencies on mageia (cyrus*, /sbin/runuser...). But
we can deal with that later.
* Not necessary for this pass, but in the hue.ini being deployed by puppet, I
don't see Hue's default sqlite db being overridden to a /var/lib/hue/* location
* Was {noformat}+ln -fs $LIB_DIR/desktop/libs/hadoop/java-lib/*plugin*jar
$PREFIX/$HADOOP_DIR{noformat} from install_hue.sh tested?
* {noformat}+# ALL_PYTHON_BORKED=`find
$BUNDLED_BUILD_DIR/env/lib/python*/site-packages/ -type f -iname "*"`{noformat}
should be killed
* Package hue should also depend on hue-common for completeness. I understand
it gets pulled through beeswax, but it is easy to forget about it and make a
mistake
* Note for later: {noformat}+ mkdir -p /usr/lib/hue/pids/ {noformat}
should be killed (actually the whole debian init script should be killed)
* if HUE_BASE_VERSION and HUE_PKG_VERSION, let HUE_PKG_VERSION reuse the
version defined by HUE_BASE_VERSION
was (Author: bmahe):
Great patch! Thanks a lot Roman.
But I see some issues as blockers. So here is a -1 since Peter put a +1.
Blocker issues:
* It does not build on anything else than Fedora. (although it looks like some
missing dependencies on the slaves)
* {quote}+Conflicts: cloudera-desktop{quote} should be killed
* I don't see any notify/subscribe in the hue puppet module (kind of a blocker,
but not really)
* bigtop-deploy/puppet/modules/hue/templates/hue.in does not have any Apache
license header
* In bigtop-packages/src/common/hue/install_hue.sh, I am pretty sure
{quote}CONF_DIR=${CONF_DIR:-/etc/hue}{quote} should be
{quote}CONF_DIR=${CONF_DIR:-/etc/hue/conf}{quote}
The most important one would be to see some green builds on jenkins.
Nice to have issues (can be dealt with separately):
* There are some missing dependencies on mageia (cyrus*, /sbin/runuser...). But
we can deal with that later.
* Not necessary for this pass, but in the hue.ini being deployed by puppet, I
don't see Hue's default sqlite db being overridden to a /var/lib/hue/* location
* Was {quote}+ln -fs $LIB_DIR/desktop/libs/hadoop/java-lib/*plugin*jar
$PREFIX/$HADOOP_DIR{quote} from install_hue.sh tested?
* {quote}+# ALL_PYTHON_BORKED=`find
$BUNDLED_BUILD_DIR/env/lib/python*/site-packages/ -type f -iname "*"`{quote}
should be killed
* Package hue should also depend on hue-common for completeness. I understand
it gets pulled through beeswax, but it is easy to forget about it and make a
mistake
* Note for later: {quote}+ mkdir -p /usr/lib/hue/pids/ {quote} should be
killed (actually the whole debian init script should be killed)
* if HUE_BASE_VERSION and HUE_PKG_VERSION, let HUE_PKG_VERSION reuse the
version defined by HUE_BASE_VERSION
> Integrate Hue 2.0.0 into Bigtop
> -------------------------------
>
> Key: BIGTOP-527
> URL: https://issues.apache.org/jira/browse/BIGTOP-527
> Project: Bigtop
> Issue Type: Sub-task
> Components: General
> Affects Versions: 0.4.0
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Fix For: 0.4.0
>
> Attachments: BIGTOP-527-3.patch.txt,
> BIGTOP-527-bruno-feedback.patch.txt, BIGTOP-527.2.patch.txt,
> BIGTOP-527.patch.txt
>
>
> Hue 2.0.0 is a major revision of Hue. It is licensed under APL and is
> available from GitHub:
>
> http://cloud.github.com/downloads/cloudera/hue/release-notes-2.0.0-beta.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
