[ 
https://issues.apache.org/jira/browse/BIGTOP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419393#comment-13419393
 ] 

Wing Yew Poon commented on BIGTOP-678:
--------------------------------------

What I meant was that, afaik, tests that use or depend on system properties or 
environment variables to parameterize behavior contain System.getProperty() or 
System.getenv() calls, so we can currently determine what the set of properties 
and variables are by grepping for System.getProperty and System.getenv in the 
test code. If instead, I start using Integer.getInteger(), then that would be 
one more (less obvious) thing to keep track of to grep for. You can imagine at 
least writing a tool (script) to come up with the "contract" (set of properties 
and variables) even in the current imperfect state of things. Changing the code 
to use Integer.getInteger() makes writing this tool a little more complex.

                
> make hive TestJdbcDriver more robust
> ------------------------------------
>
>                 Key: BIGTOP-678
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-678
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Wing Yew Poon
>            Assignee: Wing Yew Poon
>             Fix For: 0.5.0
>
>         Attachments: BIGTOP-678.txt
>
>
> I plan to attach a patch to make TestJdbcDriver more robust, by 
> parameterizing the wait time for the hive server to be up (it is currently 
> hardcoded to 1 second, which may not be long enough) and by introducing a 
> timeout to the test method (in my experience, if for some reason hive is not 
> up or otherwise able to respond successfully, the test hangs).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to