[
https://issues.apache.org/jira/browse/BIGTOP-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448557#comment-13448557
]
Bruno Mahé commented on BIGTOP-695:
-----------------------------------
Thanks a lot Anatoli for this patch!
It goes along what I was thinking when this ticket was opened (sorry for not
being more descriptive), but there are a few things that could be fixed:
* {noformat}
--flume-dir)
- FLUME_DIR=$2 ; shift 2
+ LIB_DIR=$2 ; shift 2
{noformat}
If you look at Apache Flume's rules or spec file, --flume-dir is never used.
So we could remove it or better, rename it to --lib-dir for consistency
* I would rather keep the PREFIX out of the variables. This makes it easier to
use the install script (compare the spec files of hadoop where all parameters
look like _--doc-dir=$RPM_BUILD_ROOT%{doc_hadoop}_ [in addition of already
passing the prefix as another parameter] versus hbase where they look like
_--doc-dir=%{doc_hbase}_).
In order to avoid a repetition of the pattern <PREFIX>/<DIR> from within the
script, feel free to create another set of variables or any other method of
your choice. But the lib/man/bin/etc. directories passed to the scripts should
not be already prefixed.
> Make variables used in flume build/install scripts consistent
> -------------------------------------------------------------
>
> Key: BIGTOP-695
> URL: https://issues.apache.org/jira/browse/BIGTOP-695
> Project: Bigtop
> Issue Type: Sub-task
> Components: General
> Reporter: Anatoli Fomenko
> Assignee: Anatoli Fomenko
> Fix For: 0.5.0
>
> Attachments: BIGTOP-695.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
