Re: incorrect memory usage reporting

[Ondrej Zajicek]

On Sat, Jun 28, 2014 at 12:54:41PM +0200, Job Snijders wrote:
> Hi all,
> 
> I use a BIRD instance for route collection from ~ 50 full bgp feeds [1]. The
> 'show mem' command reports very ambitious results:
> 
>     job@lg01:~$ sudo birdc show mem
>     BIRD 1.4.2 ready.
>     BIRD memory usage
>     Routing tables:   4294967294 GB
>     Route attributes: 1540 MB
>     ROA tables:        192  B
>     Protocols:         311 kB
>     Total:               0 GB
>     job@lg01:~$ free -m
>                  total       used       free     shared    buffers     cached
>     Mem:          8759       4944       3815          0        187        366
>     -/+ buffers/cache:       4390       4369
>     Swap:          486          0        486
>     job@lg01:~$
> 
> Might there be a counter that wraps around? How can I help debug this?

Hi

Does attached patch help?

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

diff --git a/lib/slab.c b/lib/slab.c
index e236e26..31529c3 100644
--- a/lib/slab.c
+++ b/lib/slab.c
@@ -123,7 +123,7 @@ static size_t
 slab_memsize(resource *r)
 {
   slab *s = (slab *) r;
-  int cnt = 0;
+  size_t cnt = 0;
   struct sl_obj *o;
 
   WALK_LIST(o, s->objs)
@@ -346,7 +346,7 @@ static size_t
 slab_memsize(resource *r)
 {
   slab *s = (slab *) r;
-  int heads = 0;
+  size_t heads = 0;
   struct sl_head *h;
 
   WALK_LIST(h, s->empty_heads)

signature.asc
Description: Digital signature