Re: birdc 2.0.0 crashes

[Ondrej Zajicek]

On Thu, Dec 14, 2017 at 04:48:37PM +0100, Clemens Schrimpe wrote:
> > And "p history_offset"? Should be 0.
> 
> Nope - it is 2:
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x00007ffff79b6a0b in previous_history () at 
> /build/readline6-RKA9OI/readline6-6.3/history.c:185
> 185   /build/readline6-RKA9OI/readline6-6.3/history.c: No such file or 
> directory.
> (gdb) p history_offset
> $1 = 2
> (gdb) p *(the_history[2])
> Cannot access memory at address 0x10
> 
> We are up to something! :-)

Hi

Perhaps it is just missing initialization? Please try attached patch.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

diff --git a/client/birdc.c b/client/birdc.c
index f1aea2fe..53a6b34e 100644
--- a/client/birdc.c
+++ b/client/birdc.c
@@ -157,6 +157,7 @@ history_init(void)
 void
 input_init(void)
 {
+  using_history();
   if (interactive)
     history_init();
   rl_readline_name = "birdc";

signature.asc
Description: PGP signature