On Wed, Jun 12, 2019 at 11:08:36AM +0000, Kenth Eriksson wrote: > > Hi > > > > We could add this feature, but it should also report more cases > > (the submitted patch covers just first two): > > > > - progress > > - done > > - progress+queued > > - config timeout running > > > The first two could be added without any refactoring. I'm not sure the > latter two can be done without some refactoring. But I can revisit > later and see if it is possible. But at least having progress and done > solves many issues since we want to know when reconfiguration is > complete. Are you willing to let it go upstream with only the first two > included?
Hi I do not like merging partial implementations and revisiting that later, as that often means changing user-visible behavior of existing features, which is something we try to avoid. Therefore, i just finished it [*]. Also, i did not use messages from cmd_reconfig_msg(), as these are appropriate as answers to requests, but not as status reports. But used the same reply codes, to ease parsing. [*] see commit 9106a750cd76d4a76c7a60294ce3a43eede166c9 > > Also i am not 100% sure if separate 'configure status' command is > > necessary, perhaps it could be part of 'show status'. But i have no > > strong strong feeling one way or the other. > > > Would prefer 'configure status', it makes sense to keep configure > request command and its status together. Also the 'show status' is > composed of lots of other stuff, making it harder to parse out when > remote controlling bird. OK -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."