On 5/17/21 19:44, Ondrej Zajicek wrote:
On Mon, May 17, 2021 at 01:48:19PM -0400, Matt Corallo wrote: You are right. My comment above is true for numeric ops, but for bitmask ops the ',' is the same as '&&', i am not really sure why. This seems confusing and it is undocumented.
Ha! right, yea, some documentation would be helpful. Just to double-check, fragmentation-type uses "," as ||, correct?
Parser receives 0x02/0x17, decomposes it to 0x2/0x2 && 0x0/0x15 (as flowspec allows just all-zero and all-one masks) and that is displayed (just with ','). We should be probably smarter and compose it back to 0x02/0x17 during display.
Eh, don't care too much about recomposition, its kinda nice to see what was received on the wire. Thanks, Matt