[Hi HS. Sorry, I just discovered this message right now, under a pile of other windows... I don't know why it was not sent. Did you have chances to work on the D skeleton since then?]
> Le 1 mars 2019 à 20:01, H. S. Teoh <[email protected]> a écrit : > > [Btw, no need to Cc: me in replies, as I'm subscribed to bison-patches] > > On Fri, Mar 01, 2019 at 06:46:43AM +0100, Akim Demaille wrote: >> Hi! >> >>> Le 1 mars 2019 à 03:10, H. S. Teoh <[email protected]> a écrit : > [...] >>> In the ideal case, the lexer would simply be a struct that wraps >>> around an arbitrary input range of characters. In order to make >>> things work with the current code, though, I conceded to make >>> CalcLexer a class that implements Lexer. We can change that when we >>> get around to moving away from lexer classes. > [...] >> The version you sent works, thanks! Is it ok if I install it under >> your name? The work is yours, not mine: (add there's a question >> for you afterwards). > > That's fine. Ok. I have updated my changes with some of yours, but not all. In particular, you keep on using YYTokenType as return value for yylex, but I changed it recently to int in the skeleton. You probably need to update your repo. > So it's really a judgment call whether we should stick to GCS or to > Phobos style. I have no strong opinions either way. (Though I have to > admit, 2-space indentation is a bit extreme... I can work with it, > though. I used to write Perl with 3-space indentation, and I *have* > seen code with 1-space indentation before. So it's not that big of a > deal.) So it will be simpler to stick to the GCS everywhere in the repo. I never used something else than 2 or 4-space indentation :) 3 sounds super weird to me :) (even when I was writing Perl, I did it the GCS way). Cheers!
