On 10/10/19 8:44 AM, Akim Demaille wrote:
I pushed this to fix issues on the CI.
commit 602d562d6f40738bede6871e555086a3a31b1fcb
Author: Akim Demaille<[email protected]>
Date: Thu Oct 10 06:26:40 2019 +0200
c: don't assume that UCHAR_MAX, etc. are defined
A number of portability issues with GCC 4.6 .. 4.9 (inclusive):
input.c:184:7: error: "UCHAR_MAX" is not defined [-Werror=undef]
#elif UCHAR_MAX <= INT_MAX
Could you explain what caused the problem? I could not reproduce the
problem with GCC 4.8.5 (I used RHEL 7.7 x86-64, which has GCC 4.8.5
20150623 (Red Hat 4.8.5-39)). This was with Bison commit
825150b08505ed83fd7257f671fb1889aa41a0e6 which came just before that patch.
GCC 4.6 .. 4.9 define UCHAR_MAX and INT_MAX, so wasn't the real problem
that <limits.h> wasn't being included when it should have been?
