I'm working on it now.
On 05/02/2019 00.28, Andreas Schildbach wrote: > It doesn't seem necessary, as signatures are not verified anyway with SPV. > > But we can support it, if you prefer. > > > On 04/02/2019 21.06, Oscar Guindzberg wrote: >> Hi Andreas, >> >> Congratulations on the progress. >> >> About freezing the codebase for 0.15 release... >> >> Probably I am missing something... >> I found BIP144 >> (https://github.com/bitcoin/bips/blob/master/bip-0144.mediawik) >> is not fully supported by the master branch. >> I mean the part where you can send a getdata with MSG_WITNESS_TX. >> https://github.com/bitcoinj/bitcoinj/pull/1420 and >> https://github.com/bitcoinj/bitcoinj/pull/1441 implement it. >> bitcoin core seems to use it too >> https://github.com/bitcoin/bitcoin/blob/5baa9092c4b8e5098b5258998f7e189ccb560495/src/net_processing.cpp#L1287-L1289 >> >> Is it not supported on purpose? Looks like we need it to tell the peer >> we want to receive txs serialized with the segwit format. >> Is there a TODO list to have full segwit support on bitcoinj? >> >> Regards, >> Oscar. >> >> On Sat, Feb 2, 2019 at 7:15 PM Manfred Karrer <[email protected]> >> wrote: >>> >>> Ah great news!!!!! >>> >>>> On 2 Feb 2019, at 23:14, Andreas Schildbach <[email protected]> wrote: >>>> >>>> I've spent the last couple of weeks finishing off support for native >>>> segwit. Please have a look at this PR; feedback welcome! >>>> >>>> https://github.com/bitcoinj/bitcoinj/pull/1563 >>>> >>>> I plan to merge this soon and -- if there are no objections -- branch >>>> the codebase off for 0.15. The release-0.15 branch will then be frozen >>>> for new features and only receive patches meant for >>>> stabilization/bigfixes. I hope to be able to release 0.15 by the end of >>>> the month. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "bitcoinj" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "bitcoinj" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >> >> >> > > -- You received this message because you are subscribed to the Google Groups "bitcoinj" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
