tree 6fadab86aec4b6dd747ebfb316396842bf1501ab
parent 6d5e8254bf488a40b7ae2faafbffa232ab19d541
author Nishanth Aravamudan <[EMAIL PROTECTED]> Tue, 19 Apr 2005 07:39:25 -0700
committer Greg K-H <[EMAIL PROTECTED]> Tue, 19 Apr 2005 07:39:25 -0700

[PATCH] USB: usb/digi_acceleport: correct wait-queue state

First patch incorrectly changed state of the wait-queue usage to
TASK_UNINTERRUPTIBLE. Reverted to TASK_INTERRUPTIBLE.

Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 usb/serial/digi_acceleport.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

Index: drivers/usb/serial/digi_acceleport.c
===================================================================
--- 
5b1da56cde518016bee4d94ba55da4f9231307f8/drivers/usb/serial/digi_acceleport.c  
(mode:100644 sha1:25f92788a6d4254284e1e71111b80b84fb5ca1aa)
+++ 
6fadab86aec4b6dd747ebfb316396842bf1501ab/drivers/usb/serial/digi_acceleport.c  
(mode:100644 sha1:a19a47f6cf12a1acee1224218b0eb6d6bc17090b)
@@ -568,6 +568,9 @@
 *  and the sleep.  In other words, spin_unlock_irqrestore and
 *  interruptible_sleep_on_timeout are "atomic" with respect to
 *  wake ups.  This is used to implement condition variables.
+*
+*  interruptible_sleep_on_timeout is deprecated and has been replaced
+*  with the equivalent code.
 */
 
 static inline long cond_wait_interruptible_timeout_irqrestore(
@@ -576,13 +579,12 @@
 {
        DEFINE_WAIT(wait);
 
-       prepare_to_wait(q, &wait, TASK_UNINTERRUPTIBLE);
+       prepare_to_wait(q, &wait, TASK_INTERRUPTIBLE);
        spin_unlock_irqrestore(lock, flags);
        timeout = schedule_timeout(timeout);
        finish_wait(q, &wait);
 
        return timeout;
-
 }
 
 
@@ -1596,7 +1598,7 @@
                        dbg( "digi_close: write oob failed, ret=%d", ret );
 
                /* wait for final commands on oob port to complete */
-               prepare_to_wait(&priv->dp_flush_wait, &wait, 
TASK_UNINTERRUPTIBLE);
+               prepare_to_wait(&priv->dp_flush_wait, &wait, 
TASK_INTERRUPTIBLE);
                schedule_timeout(DIGI_CLOSE_TIMEOUT);
                finish_wait(&priv->dp_flush_wait, &wait);
 
@@ -1995,7 +1997,7 @@
 
                } else if( opcode == DIGI_CMD_IFLUSH_FIFO ) {
 
-                       wake_up( &priv->dp_flush_wait );
+                       wake_up_interruptible( &priv->dp_flush_wait );
 
                }
 
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to