Bugs item #833071, was opened at 2003-10-30 15:05
Message generated for change (Comment added) made by bradleyhughes
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=428680&aid=833071&group_id=40696

Category: Behaviour
Group: 0.65.x
Status: Closed
Resolution: Out of Date
Priority: 5
Submitted By: Christian Biere (cbiere)
Assigned to: Nobody/Anonymous (nobody)
Summary: Invalid signal handling

Initial Comment:
Please fix src/BaseDisplay.cc:

BaseDisplay::BaseDisplay():
 - Don't connect any signal handlers to SIGFPE or
SIGSEGV - unless 
    you have very good reasons to to so.

signalhandler():
 - You MUST NOT use fprintf() in any signalhandler!
 - You MUST NOT use exit() in any signalhandler either,
use _exit().
 - base_display->handleSignal() is a pure virtual
method but the instance
   base_display hasn't been completely initialised yet
in all cases because
   the signalhandler is connected from the constructor
of the object.
 - You might want to apply the signalhandler to SIGQUIT
as well.

----------------------------------------------------------------------

>Comment By: Bradley T. Hughes (bradleyhughes)
Date: 2004-09-06 08:42

Message:
Logged In: YES 
user_id=459209

wrong, the signal handler in CVS (lib/Application.cc) does
not do anything but set a single bit in a sig_atomic_t. :)

----------------------------------------------------------------------

Comment By: Christian Biere (cbiere)
Date: 2004-09-03 15:57

Message:
Logged In: YES 
user_id=643728

This one still stands:

signalhandler():
- You MUST NOT use fprintf() in any signalhandler!

You can use write(STDERR_FILENO, ...) instead.

----------------------------------------------------------------------

Comment By: Bradley T. Hughes (bradleyhughes)
Date: 2004-09-03 15:14

Message:
Logged In: YES 
user_id=459209

the code in question has been rewritten propertly in CVS 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=428680&aid=833071&group_id=40696

-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
List archives:  http://asgardsrealm.net/lurker/splash/index.html
Trouble? Contact [EMAIL PROTECTED]

Reply via email to