On 02/06/16 13:26, Fernando de Oliveira wrote:
Em 05-02-2016 13:48, Tim Tassonis escreveu:
Hi all

I just install curl from blfs and would suggest a minor correction to
the install section:

find docs \( -name Makefile\* \
           -o -name \*.1       \
           -o -name \*.3 \)    \
           -exec rm {} \;      &&
install -v -d -m755 /usr/share/doc/curl-7.47.0 &&
cp -v -R docs/*     /usr/share/doc/curl-7.47.0


This works ok, but it has the effect that the build directory gets
broken, e.g. a following make (or make install) will miss files and
fail. Also, it will still copy a
/usr/share/doc/curl-7.47.0/examples/.deps folder that is unneeded.
Therefore I suggest to change this to:

install -v -d -m755 /usr/share/doc/curl-7.47.0 &&
cp -v -R docs/* /usr/share/doc/curl-7.47.0 &&
find /usr/share/doc/curl-7.47.0 \( -name Makefile\* \
-o -name \*.1 \
-o -name \*.3 \) \
-exec rm {} \; &&
rm -rf /usr/share/doc/curl-7.47.0/examples/.deps

This will leave the build directory unharmed and do the necessary
cleanups in the destination directory.

Wontfix.

Thanks.

<http://wiki.linuxfromscratch.org/blfs/ticket/7432>

Fine me with, although I don't understand the refusal to change one single line that won't harm anything. The reason I'm suggesting this is that one simple typo in those three lines will force you to fully unpack, ./configure and make the whole package again, only to be able to call "make install" again.

I won't bother commenting on your refusal to accept that it's a good idea to remove the unneeded .deps Directory in the resulting docucment...




--
decentral.ch - IT Stuff
Tim Tassonis
Dennlerstasse 36
8047 Zürich

[email protected]
+41 79 229 36 17
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to