There is an order of precedence error in the logic to set the background
image for fluxbox.

If ~/.fluxbox/theme is a file, then both echo statements to set the theme
background image below get executed, but only the first one should.  This
is because && and || have the same precedence so everything happens left to
right.

So if ~/.fluxbox/theme is a file this:

[ -f ~/.fluxbox/theme ] &&
echo "background.pixmap: </path/to/nice/image.ext>" >> ~/.fluxbox/theme ||
[ -d ~/.fluxbox/theme ] &&
echo "background.pixmap: </path/to/nice/image.ext>" >>
~/.fluxbox/theme/theme.cfg

Becomes:

true ||
[ -d ~/.fluxbox/theme ] &&
echo "background.pixmap: </path/to/nice/image.ext>" >>
~/.fluxbox/theme/theme.cfg

Which becomes:

true &&
echo "background.pixmap: </path/to/nice/image.ext>" >>
~/.fluxbox/theme/theme.cfg

Which executes:
echo "background.pixmap: </path/to/nice/image.ext>" >>
~/.fluxbox/theme/theme.cfg

at which point an error occurs because ~/.fluxbox/theme is a file not a
directory

The attached patch works for both theme cases without error.

Attachment: fluxbox.xml.diff
Description: Binary data

-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to