On 7/11/19 6:53 PM, Tim Tassonis via blfs-dev wrote:
On 7/11/19 6:38 PM, Paul Menzel wrote:
Dear Tim, dear Douglas,
On 7/11/19 6:34 PM, Douglas R. Reno via blfs-dev wrote:
On Thu, Jul 11, 2019, 11:32 AM Tim Tassonis wrote:
Just wanted to let you know that thunderbird seems not to build out of
the box with rustc 1.35.0. I'm currently looking for
solutions/patches,
seems that ubuntu has something. If anybody has seen a patch regarding
"fix-missing-docs-error", I'd welcome any pointers, of course.
The errors I get are:
39:03.01 error: missing documentation for macro
39:03.01 --> servo/components/style_traits/values.rs:139:1
39:03.01 |
39:03.01 139 | macro_rules! serialize_function {
39:03.01 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
39:03.01 |
39:03.01 note: lint level defined here
39:03.01 --> servo/components/style_traits/lib.rs:12:22
39:03.01 |
39:03.01 12 | #![deny(unsafe_code, missing_docs)]
39:03.01 | ^^^^^^^^^^^^
39:03.01
39:03.02 error: missing documentation for macro
39:03.02 --> servo/components/style_traits/values.rs:408:1
39:03.02 |
39:03.02 408 | macro_rules! define_css_keyword_enum {
39:03.02 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
39:03.02
39:03.02 error: aborting due to 2 previous errors
39:03.02
39:03.15 error: Could not compile `style_traits`.
39:03.15
Did you try the rust fix patch that Ken had implemented for 60.7.2? I
think
that fixes something with this, but I'm not 100% certain.
The change below fixed it for us [1].
sed -i -e '/#!\[deny(missing_docs)\]/d'
servo/components/style/lib.rs
This should work, as it disables any errors for missing_docs in general,
which I personally also think is sensible.
However, I found a patch at archlinux that actually should "add" that
"docs", by inserting some "///" lines.
diff -ruN
thunderbird-60.8.0/servo/components/style/properties/properties.mako.rs
thunderbird-60.8.0-fix-missing-docs-error/servo/components/style/properties/properties.mako.rs
---
thunderbird-60.8.0/servo/components/style/properties/properties.mako.rs
2019-07-03 17:25:27.000000000 +0200
+++
thunderbird-60.8.0-fix-missing-docs-error/servo/components/style/properties/properties.mako.rs
2019-07-11 18:39:43.035635036 +0200
@@ -55,6 +55,7 @@
pub use self::declaration_block::*;
+/// Generated
#[cfg(feature = "gecko")]
#[macro_export]
macro_rules! property_name {
@@ -3853,6 +3854,7 @@
}
// NOTE(emilio): Callers are responsible to deal with prefs.
+/// Callers are responsible to deal with prefs.
#[macro_export]
macro_rules! css_properties_accessors {
($macro_name: ident) => {
@@ -3875,6 +3877,7 @@
}
}
+/// Neco
#[macro_export]
macro_rules! longhand_properties_idents {
($macro_name: ident) => {
I will try that first, if it helps, I will upload the patch and add it.
I will also mention that the sed should be enough.
It did not fix the errors, so I'm going for the sed now, which seems a
good solution to me.
Bye
Tim
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
