LGTM2 /Daniel
On 2021-09-23 12:06, Yoav Weiss wrote:
LGTM1On Wed, Sep 22, 2021 at 5:21 AM Tsuyoshi Horo <h...@chromium.org <mailto:h...@chromium.org>> wrote:Contact emails h...@chromium.org <mailto:h...@chromium.org> Explainer https://github.com/horo-t/explainers/blob/main/script_element_supports.md <https://github.com/horo-t/explainers/blob/main/script_element_supports.md> Specification https://html.spec.whatwg.org/multipage/scripting.html#dom-script-supports <https://html.spec.whatwg.org/multipage/scripting.html#dom-script-supports> Design docs https://github.com/horo-t/explainers/blob/main/script_element_supports.md <https://github.com/horo-t/explainers/blob/main/script_element_supports.md> Summary Provides a unified way to detect new features that use script elements. Blink component Blink>HTML>Script <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHTML%3EScript> TAG review https://github.com/w3ctag/design-reviews/issues/674 <https://github.com/w3ctag/design-reviews/issues/674> TAG review status Issues addressedIt should be noted that there was disagreement <https://github.com/w3ctag/design-reviews/issues/674#issuecomment-920189749> between the TAG and the spec authors on the naming. While I lean towards the call the spec authors made, the need for better JS feature detection is something I repeatedly hear both from the TAG and <https://docs.google.com/document/d/1zxs8kZVUtyqWzRr9SaXGOwrRAOBOYTMRs4MZJ9ahK98/edit?resourcekey=0-xW4ilB9FrmJFkRIOumTTPQ#heading=h.c0uts5ftkk58> others <https://github.com/whatwg/html/issues/4432>. Orthogonal to this intent, this seems like something we should eventually tackle.Risks Interoperability and Compatibility This method provides a synchronous way of feature detections. But for unsupported browsers, developers need to use an asynchronous way as discussed athttps://github.com/WICG/import-maps/issues/171 <https://github.com/WICG/import-maps/issues/171>.Is it worthwhile to document the desired code patterns we want developers to use? (e.g. test is `supports()` exists and fallback to the async method otherwise)Gecko: Worth prototyping (https://github.com/mozilla/standards-positions/issues/576 <https://github.com/mozilla/standards-positions/issues/576>) WebKit: No signal (https://lists.webkit.org/pipermail/webkit-dev/2021-September/031979.html <https://lists.webkit.org/pipermail/webkit-dev/2021-September/031979.html>) Web developers: Positive The developer feedback on the spec issue (https://github.com/whatwg/html/issues/6472 <https://github.com/whatwg/html/issues/6472>) was positive. Ergonomics No known ergonomics risks. Activation No known activation risks. This method is easy to use. Security No known security risks. Debuggability Developers can call this method from DevTools's console. Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>? Yes DevTrial instructions https://github.com/horo-t/explainers/blob/main/script_element_supports_how_to.md <https://github.com/horo-t/explainers/blob/main/script_element_supports_how_to.md> Flag name ScriptElementSupports Requires code in //chrome? False Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1245528 <https://bugs.chromium.org/p/chromium/issues/detail?id=1245528> Sample links https://horo-t.github.io/explainers/script_element_supports_sample.html <https://horo-t.github.io/explainers/script_element_supports_sample.html> Estimated milestones DevTrial on desktop95 DevTrial on android95 DevTrial on Webview95 Link to entry on the Chrome Platform Status https://www.chromestatus.com/feature/5712146835963904 <https://www.chromestatus.com/feature/5712146835963904> Links to previous Intent discussions Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/evk2qgsekYk/m/WtdE_XplBQAJ <https://groups.google.com/a/chromium.org/g/blink-dev/c/evk2qgsekYk/m/WtdE_XplBQAJ> Ready for Trial: https://groups.google.com/a/chromium.org/g/blink-dev/c/-sE2GpCrG6Y/m/UsHXyVW-CAAJ <https://groups.google.com/a/chromium.org/g/blink-dev/c/-sE2GpCrG6Y/m/UsHXyVW-CAAJ> This intent message was generated by Chrome Platform Status <https://www.chromestatus.com/>.-- You received this message because you are subscribed to the GoogleGroups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org <mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADk0S-Vi%2BhCDOA2y0%2BfUU-dt60_ySvSY0-MjDyGTMi8oHcrm9A%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADk0S-Vi%2BhCDOA2y0%2BfUU-dt60_ySvSY0-MjDyGTMi8oHcrm9A%40mail.gmail.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org <mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV1cuHkDVpSbirXFPc7Ej5cX4hcpQumcwkK39988%3DDRyg%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV1cuHkDVpSbirXFPc7Ej5cX4hcpQumcwkK39988%3DDRyg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/05ff649c-5127-3740-80d2-482539ba48b7%40gmail.com.
