Thanks for the LGTMs. I filed WebKit bug 231361 <https://bugs.webkit.org/show_bug.cgi?id=231361> for implementing perspective(none) in WebKit, and for MDN documentation of perspective() I created PR mdn/content#9653 <https://github.com/mdn/content/pull/9653> (fixing some other issues as well) and filed issue mdn/browser-compat-data#12742 <https://github.com/mdn/browser-compat-data/issues/12742>.
It's indeed expected that the existing WPT tests for perspective(none) are all passing in Firefox since they were all added as part of the patch that implemented it in Firefox. I have one more WPT test addition in the Chromium patch. -David On Thu, Oct 7, 2021 at 3:55 AM Philip Jägenstedt <foo...@chromium.org> wrote: > LGTM3, this is an easy case, an improvement to an existing feature already > on track to ship in another browser. > > Although not part of our launch process, can I ask what documentation > updates will be needed here? > https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function/perspective() > doesn't mention "none" at all, is that the page to update? If so, a new > entry in the compat table at the bottom of the page would also be a good > idea. If it's clear what needs to be done, would you mind filing issues at > https://github.com/mdn/content/issues and > https://github.com/mdn/browser-compat-data/issues? (Again, not a proper > part of our launch process, so optional.) > > For WPT, indeed it looks like this is already passing in Firefox: > > https://wpt.fyi/results/css/css-transforms/animation/transform-interpolation-001.html?label=experimental&label=master&aligned > > On Thu, Oct 7, 2021 at 8:49 AM Manuel Rego Casasnovas <r...@igalia.com> > wrote: > >> LGTM2 >> >> On 07/10/2021 08:07, Yoav Weiss wrote: >> > LGTM1 >> > >> > On Mon, Oct 4, 2021 at 10:42 PM David Baron <dba...@chromium.org >> > <mailto:dba...@chromium.org>> wrote: >> > >> > >> > Contact emails >> > >> > dba...@chromium.org <mailto:dba...@chromium.org> >> > >> > >> > Explainer >> > >> > None >> > >> > >> > Specification >> > >> > https://drafts.csswg.org/css-transforms-2/#funcdef-perspective >> > <https://drafts.csswg.org/css-transforms-2/#funcdef-perspective> >> > >> > >> > Summary >> > >> > Implement support for a 'none' argument to the perspective() >> > function within the syntax of the CSS transform property. This >> > provides the perspective() function with a value that gives the >> > identity matrix. Its effect is as though the perspective() function >> > was given an argument that is infinite. This makes it easier (or, in >> > some cases, possible) to do animations involving the perspective() >> > function where one of the endpoints of the animation is the identity >> > matrix. >> > >> > >> > >> > Blink component >> > >> > Blink>CSS >> > < >> https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> >> > >> > >> > Search tags >> > >> > css <https://chromestatus.com/features#tags:css>, transform >> > <https://chromestatus.com/features#tags:transform>, perspective >> > <https://chromestatus.com/features#tags:perspective> >> > >> > >> > TAG review >> > >> > Not needed for a single value addition to a single function within a >> > CSS property. >> > >> > >> > TAG review status >> > >> > Not applicable >> > >> > >> > Risks >> > >> > >> > >> > Interoperability and Compatibility >> > >> > >> > >> > Gecko: Shipped/Shipping >> > (https://bugzilla.mozilla.org/show_bug.cgi?id=1725207 >> > <https://bugzilla.mozilla.org/show_bug.cgi?id=1725207>) Will ship >> > very soon in Firefox 93. >> > >> > WebKit: No signal >> > ( >> https://github.com/w3c/csswg-drafts/issues/6488#issuecomment-896962025 >> > < >> https://github.com/w3c/csswg-drafts/issues/6488#issuecomment-896962025>) >> > Safari developers participated in the CSS Working Group discussion >> > about adding it and were ok with the addition. I recognize this >> > isn't an official signal, but this seems perhaps too small a feature >> > to ask for an explicit one. >> > >> > >> > Can you file a webkit bug for this? >> > >> > >> > >> > Web developers: Positive >> > (https://bugzilla.mozilla.org/show_bug.cgi?id=1723266#c2 >> > <https://bugzilla.mozilla.org/show_bug.cgi?id=1723266#c2>) this is >> > the one explicit signal from a developer that I could find >> > >> > >> > Debuggability >> > >> > Should be equally debuggable as existing values of the perspective() >> > function. >> > >> > >> > >> > Is this feature fully tested by web-platform-tests >> > < >> https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md >> >? >> > >> > Yes >> > >> > >> > Flag name >> > >> > >> > >> > Requires code in //chrome? >> > >> > False >> > >> > >> > Tracking bug >> > >> > https://bugs.chromium.org/p/chromium/issues/detail?id=1253596 >> > <https://bugs.chromium.org/p/chromium/issues/detail?id=1253596> >> > >> > >> > Estimated milestones >> > >> > No milestones specified >> > >> > >> > >> > Link to entry on the Chrome Platform Status >> > >> > https://chromestatus.com/feature/5687325523705856 >> > <https://chromestatus.com/feature/5687325523705856> >> > >> > This intent message was generated by Chrome Platform Status >> > <https://www.chromestatus.com/>. >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "blink-dev" group. >> > To unsubscribe from this group and stop receiving emails from it, >> > send an email to blink-dev+unsubscr...@chromium.org >> > <mailto:blink-dev+unsubscr...@chromium.org>. >> > To view this discussion on the web visit >> > >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAG0MU3iW8-GYebwN6TF8WCCKLcQNEVkqunuoPSL%2BkPrPW1u0qQ%40mail.gmail.com >> > < >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAG0MU3iW8-GYebwN6TF8WCCKLcQNEVkqunuoPSL%2BkPrPW1u0qQ%40mail.gmail.com?utm_medium=email&utm_source=footer >> >. >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "blink-dev" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an email to blink-dev+unsubscr...@chromium.org >> > <mailto:blink-dev+unsubscr...@chromium.org>. >> > To view this discussion on the web visit >> > >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%3D1-QAq_7pQnPDzMNz9BH0cc3cmYDbyinzcT15J8iv4g%40mail.gmail.com >> > < >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%3D1-QAq_7pQnPDzMNz9BH0cc3cmYDbyinzcT15J8iv4g%40mail.gmail.com?utm_medium=email&utm_source=footer >> >. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/00db19cc-7acb-df58-19aa-06a1ea192e7c%40igalia.com >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAG0MU3iRK12jNs%3D0JT%2Bs4Dng0Jx2Fun4Cc41qjYbWGVvOeAx8Q%40mail.gmail.com.
