LGTM3 /Daniel
On 2021-10-07 20:58, Chris Harrelson wrote:
LGTM2 On Thu, Oct 7, 2021 at 11:57 AM Mike West <mk...@chromium.org> wrote: Extending the existing support from Android and Windows to Mac and Linux is quite reasonable. LGTM1. That said, it would be ideal to ping https://github.com/mozilla/standards-positions/issues/338 in the hopes of keeping this on Mozilla's radar in the hopes of eventual interop. -mike On Thu, Oct 7, 2021 at 6:53 PM 'Ajay Rahatekar' via blink-dev <blink-dev@chromium.org> wrote: Contact emails mjack...@microsoft.com <mailto:mjack...@microsoft.com>, mandy.c...@microsoft.com <mailto:mandy.c...@microsoft.com>, est...@google.com <mailto:est...@google.com>, ajayrahate...@google.com Explainer Shortcuts Explainer <https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Shortcuts/explainer.md> Spec W3C spec:https://w3c.github.io/manifest/#shortcuts-member <https://w3c.github.io/manifest/#shortcuts-member> Tag Review:https://github.com/w3ctag/design-reviews/issues/510 <https://github.com/w3ctag/design-reviews/issues/510> Summary This feature provides PWA developers the ability to show a shortcuts menu of common tasks in their app. The menu can be invoked by right clicking the app icon in the quick launch bar after the PWA has been installed on the user’s desktop, or long pressing on the app on Android. This capability already exists for native apps on various platforms (Android, Linux, macOS, and Windows). Link to “Intent to Prototype” blink-dev discussion https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gK4XF2vbvf0 <https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gK4XF2vbvf0> Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? This feature was previously shipped for Windows and Android https://groups.google.com/a/chromium.org/g/blink-dev/c/FgzYX7AFbUQ/m/f2i0-f-BAQAJ <https://groups.google.com/a/chromium.org/g/blink-dev/c/FgzYX7AFbUQ/m/f2i0-f-BAQAJ> Requesting approval to ship on Mac and Linux https://bugs.chromium.org/p/chromium/issues/detail?id=1248101 <https://bugs.chromium.org/p/chromium/issues/detail?id=1248101> Demo link Test Website <https://sadchonks.com/>. The enable-desktop-pwas-app-icon-shortcuts-menu-ui flag needs to be enabled. Risks Interoperability and Compatibility No Interoperability/Compatibility risk. When a web developer doesn’t provide a shortcuts member in the PWA’s WebAppManifest, current installation behavior is not affected by this feature. Edge: In development/Public Support Firefox: No signals Safari: No signals Web / Framework developers: Positive feedback from web developers Ergonomics Shortcuts will be used as part of the WebAppManifest. Use will not affect performance. Activation Use will be straightforward, it will only require developers to list their shortcuts in their manifest. Is this feature fully tested byweb-platform-tests <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>? Link to test suite results fromwpt.fyi <https://wpt.fyi/>. Pre-existing manual WPT tests exist: appmanifest/shortcuts-member/ <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/appmanifest/shortcuts-member/> Entry on thefeature dashboard <http://www.chromestatus.com/> https://www.chromestatus.com/feature/5706099464339456 <https://www.chromestatus.com/feature/5706099464339456>-- Ajay Rahatekar | Technical Program Manager|ajayrahate...@google.com |650-797-1279 <tel:(650)%20650-797-1279>-- You received this message because you are subscribed to theGoogle Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHB%2BDAgpD1v%2Bp0Y4HtXa43TiySyA_R0_%3Do4Dg4U1AJtQrQu_vQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHB%2BDAgpD1v%2Bp0Y4HtXa43TiySyA_R0_%3Do4Dg4U1AJtQrQu_vQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.-- You received this message because you are subscribed to the GoogleGroups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DdFdH6rqKq7yCZWgiHueWxjhwoJGLJ8pN%2BA4bhBQX1uSw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DdFdH6rqKq7yCZWgiHueWxjhwoJGLJ8pN%2BA4bhBQX1uSw%40mail.gmail.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-eXy%2BxAXCUc%2BKt4L3C3kN7%3DzOUJz8eA4CaTzTLtF8Mng%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-eXy%2BxAXCUc%2BKt4L3C3kN7%3DzOUJz8eA4CaTzTLtF8Mng%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/950aeecc-db7b-a495-b48a-676ebaef826a%40gmail.com.
