LGTM3 On Fri, Oct 29, 2021 at 12:18 AM Manuel Rego Casasnovas <r...@igalia.com> wrote:
> LGTM2 > > On 29/10/2021 06:56, Yoav Weiss wrote: > > LGTM1 > > > > On Thu, Oct 28, 2021 at 10:56 PM Andreu Botella > > <and...@andreubotella.com <mailto:and...@andreubotella.com>> wrote: > > > > I don't think the differences are listed anywhere. I know there are > > some because of the failures in > > > https://wpt.fyi/results/html/infrastructure/safe-passing-of-structured-data?label=experimental&label=master&aligned > > < > https://wpt.fyi/results/html/infrastructure/safe-passing-of-structured-data?label=experimental&label=master&aligned > >, > > but there might be others that aren't tested. Although it seems like > > some of the failures in the shared-array-buffer folder seem to be > > bugs with the tests rather than with the implementations. > > > > > > OK, as these differences are already exposed, I don't think shipping > > this significantly increases risk. The fact that they're covered by WPTs > > makes it more likely we'd (eventually) converge on the specified > behavior. > > > > > > On Wednesday, October 27, 2021 at 11:12:32 PM UTC+2 > > fs...@chromium.org <mailto:fs...@chromium.org> wrote: > > > > This is amazing! :) > > > > I agree it shouldn't block this, but do we have anywhere written > > what are the browser's differences on structured clone > > algorithms? Is it a spec issue? Could we add WPT tests for it? > > > > On Wed, Oct 27, 2021 at 2:45 PM Andreu Botella > > <and...@andreubotella.com> wrote: > > > > *Contact emails* > > and...@andreubotella.com, jbr...@chromium.org, > > su...@chromium.org > > > > *Explainer* > > https://github.com/whatwg/html/issues/793 > > <https://github.com/whatwg/html/issues/793> > > > > *Specification* > > https://html.spec.whatwg.org/#structured-cloning > > <https://html.spec.whatwg.org/#structured-cloning> > > > > *Summary* > > Enables using the HTML structured clone algorithm > > synchronously for cloning and transferring objects within a > > single realm. > > > > *Initial public proposal* > > https://github.com/whatwg/html/issues/793 > > <https://github.com/whatwg/html/issues/793> > > https://github.com/whatwg/html/pull/3414 > > <https://github.com/whatwg/html/pull/3414> > > > > *Blink component* > > Blink>Messaging > > < > https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMessaging > > > > > > > > *TAG review* > > This is just exposing existing browser functionality, with a > > two-line spec. It doesn’t seem like there’s much to discuss > > architecturally, but I’ll file for review if the community > > thinks it would help. > > > > *TAG review status* > > Not applicable > > > > *Risks* > > > > *Interoperability and Compatibility* > > Low. There are some differences across the browsers’ > > implementations of the structured cloning algorithm, but > > they are very minor and already present in other APIs that > > use it. > > > > Gecko: Shipped/Shipping > > (https://bugzilla.mozilla.org/show_bug.cgi?id=1722576 > > <https://bugzilla.mozilla.org/show_bug.cgi?id=1722576>) > > Edge: No signal > > WebKit: Shipped/Shipping > > (https://bugs.webkit.org/show_bug.cgi?id=228331 > > <https://bugs.webkit.org/show_bug.cgi?id=228331>) > > > > Web developers: Positive > > ( > https://github.com/whatwg/html/pull/3414#issuecomment-854051942 > > < > https://github.com/whatwg/html/pull/3414#issuecomment-854051942> > > and following comments). There seems to be a lot of demand > > for a built-in deep clone, and while structured clone is not > > exactly that, it fulfills many of the use cases. > > > > *Debuggability* > > n/a > > > > *Is this feature fully tested by web-platform-tests > > < > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > >?* > > Yes > > < > https://wpt.fyi/results/html/webappapis/structured-clone?label=experimental&label=master&aligned > > > > > > > > *Requires code in //chrome?* > > False > > > > *Tracking bug* > > > https://bugs.chromium.org/p/chromium/issues/detail?id=1233571 < > https://bugs.chromium.org/p/chromium/issues/detail?id=1233571> > > > > > > *Estimated milestones* > > No milestones specified > > > > *Link to entry on the Chrome Platform Status* > > https://chromestatus.com/feature/5630001077551104 > > <https://chromestatus.com/feature/5630001077551104> > > > > *Requesting approval to ship? * > > Yes. This is a relatively small feature which exposes > > existing functionality. > > > > -- > > You received this message because you are subscribed to the > > Google Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails > > from it, send an email to blink-dev+...@chromium.org. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e7299674-54df-4f4d-8c30-d922ebf4e47cn%40chromium.org > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e7299674-54df-4f4d-8c30-d922ebf4e47cn%40chromium.org?utm_medium=email&utm_source=footer > >. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/74ab6933-2925-455a-9e24-a95ae08f3cf5n%40chromium.org > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/74ab6933-2925-455a-9e24-a95ae08f3cf5n%40chromium.org?utm_medium=email&utm_source=footer > >. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVnABD048Xi6r3J9%2BGwBmYUX6pM1Auqp6MQSuwJUaNejg%40mail.gmail.com > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVnABD048Xi6r3J9%2BGwBmYUX6pM1Auqp6MQSuwJUaNejg%40mail.gmail.com?utm_medium=email&utm_source=footer > >. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/aeed9b84-edb0-d0fb-5d3d-2e931f5f2b7b%40igalia.com > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8Gqt5DnrkCkB-1x8ORZQBw6zFTbOfkwp_rq9Jgs-3Qjg%40mail.gmail.com.
