LGTM3. On Wed 24. Nov 2021 at 23:59 Rick Byers <rby...@chromium.org> wrote:
> Makes sense, thanks! Arguably almost a bugfix level change. LGTM2 > > On Wed, Nov 24, 2021 at 5:27 PM Ben Kelly <wanderv...@chromium.org> wrote: > >> >> >> On Wed, Nov 24, 2021, 5:07 PM Rick Byers <rby...@chromium.org> wrote: >> >>> Ben, can you speak to the web compat implications (or absence thereof) >>> to this change in behavior? >>> >> >> I believe the compat risk should be minimal. This change only matters >> for navigation requests and many service workers will be using nav preload >> instead of calling fetch() themselves. >> >> For sites not using nav preload it's possible they will see changes in >> origin headers, sec-fetch-site headers, and SameSite=Strict cookies. >> Depending on server logic that could cause requests to be deemed unsafe by >> the server and fail. However, it would match what is done without a >> service worker present. Arguably the server wants to make this decision in >> these situations. >> >> If a site does not want this behavior it requires only a small service >> worker change to get previous behavior. They just need to fetch the url >> and not the full request. Like `fetch(evt.request.url)` instead of >> `fetch(evt.request)`. >> >> Nov 24, 2021 at 5:03 PM Chris Harrelson <chris...@chromium.org> wrote: >>> >>>> LGTM1 >>>> >>>> On Wed, Nov 24, 2021 at 1:52 PM Ben Kelly <wanderv...@chromium.org> >>>> wrote: >>>> >>>>> On Wed, Nov 24, 2021 at 4:40 PM Ben Kelly <wanderv...@chromium.org> >>>>> wrote: >>>>> >>>>>> Interoperability and Compatibility >>>>>> >>>>>> >>>>>> >>>>>> Gecko: No signal >>>>>> >>>>> >>>>> I have not filed for formal signals, but we had a TPAC session >>>>> <https://github.com/w3c/ServiceWorker/issues/1604> with mozilla where >>>>> we reached consensus on these changes. >>>>> >>>>> >>>>>> WebKit: No signal >>>>>> >>>>> >>>>> Note, webkit already propagates the origin header. They do not >>>>> implement sec-fetch-site or SameSite cookies, so the redirect chain >>>>> propagation is not observable or relevant. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK7rkMjWDoVDeuNnYVuOOS4OjEKrRUkKSt9G9CwT13T_PPS6nQ%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK7rkMjWDoVDeuNnYVuOOS4OjEKrRUkKSt9G9CwT13T_PPS6nQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9_ytnSVS4%2BciMFChuTsKEUOC0WJ_0c0-Q3Ue5eyXi8zQ%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9_ytnSVS4%2BciMFChuTsKEUOC0WJ_0c0-Q3Ue5eyXi8zQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8_ouG4MC9SkJ-gMDi7vSFYGfw5EvNEbquUcjoCuhLkGw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8_ouG4MC9SkJ-gMDi7vSFYGfw5EvNEbquUcjoCuhLkGw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -mike -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DdkhAGWCdgV2ekvDr_y5Z8PLmemZZ66t7j8y-NGA6TaQQ%40mail.gmail.com.
