LGTM2 On Sun, Dec 12, 2021 at 10:47 PM Yoav Weiss <yoavwe...@chromium.org> wrote:
> *LGTM1* > > Thanks for fixing the related CSSPreloadScanner issues! :) > > On Sat, Dec 11, 2021 at 5:58 AM Xiaocheng Hu <xiaoche...@chromium.org> > wrote: > >> It's flipped to "experimental" in 99.0.4759.0. We should see all the >> tests (except crbug.com/1277637) turn green soon. >> >> It also appears that the test failures are properly tracked at Gecko and >> WebKit, detailed as below: >> >> For Gecko, the failures are already tracked by: >> - CSSOM API-related: https://bugzilla.mozilla.org/show_bug.cgi?id=1745233 >> - 'revert-layer' keyword: >> https://bugzilla.mozilla.org/show_bug.cgi?id=1699220 >> - Remaing failures already have tracking bugs as shown by wpt.fyi >> >> For WebKit, their failing tests are: >> - Those testing interactions with certain at-rules (@counter-style, >> @property, @scroll-timeline) that they don't support yet. >> - CSSOM API-related, which they fixed recently ( >> https://trac.webkit.org/changeset/286657/webkit). Should turn green in >> wpt.fyi soon >> - The remaining failures are already tracked by >> https://bugs.webkit.org/show_bug.cgi?id=233937, >> https://bugs.webkit.org/show_bug.cgi?id=233944 and >> https://bugs.webkit.org/show_bug.cgi?id=234158 >> >> >> On Thu, Dec 9, 2021 at 2:59 PM Manuel Rego Casasnovas <r...@igalia.com> >> wrote: >> >>> >>> >>> On 08/12/2021 18:48, Xiaocheng Hu wrote: >>> > They are failing on wpt.fyi because the feature is not enabled there. >>> > The feature is not behind the "experimental web platform features" >>> flag. >>> >>> Isn't a bit strange to move a runtime feature from "test" to "stable", >>> without having been in "experimental" for a while? >>> Maybe it'd be nice to maybe mark it as "experimental" and see lots of >>> green tests in wpt.fyi. >>> >>> It looks interoperability is not great yet, as Firefox and Safari fail a >>> bunch of tests here and there. It would be nice if we could fill bugs >>> (if they haven't been filled yet) for some of the biggest interop issues >>> we think web authors will find. >>> >>> Cheers, >>> Rego >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhZ%2BbXqgPQsSOc%2B4vEhTm1Rck%2BZ5CQ8n2nJXzeKUOKsTxA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhZ%2BbXqgPQsSOc%2B4vEhTm1Rck%2BZ5CQ8n2nJXzeKUOKsTxA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUrsF%2Bvs2VZwtLXcJaZZQ8F8ek%3DJZ5k3srv_U5CF9q05w%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUrsF%2Bvs2VZwtLXcJaZZQ8F8ek%3DJZ5k3srv_U5CF9q05w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-nwOMNLQsCVOeNUO1tSC_pYHAJkZDtGsBZVFCLO9gUKg%40mail.gmail.com.
