LGTM3 On Fri, Apr 15, 2022, 18:20 Rouslan Solomakhin <[email protected]> wrote:
> > > On Fri, Apr 15, 2022 at 9:44 AM Mike Taylor <[email protected]> > wrote: > >> On 4/15/22 12:31 AM, Yoav Weiss wrote: >> >> On Mon, Apr 11, 2022 at 4:45 PM Rouslan Solomakhin <[email protected]> >> wrote: >> >>> Contact emails >>> >>> [email protected], [email protected] >>> >>> Explainer >>> >>> https://github.com/WICG/digital-goods/blob/main/explainer.md#api-v21 >>> >>> Specification >>> >>> https://wicg.github.io/digital-goods/ >>> >>> Difference between 2.0 and 2.1 >>> <https://pr-preview.s3.amazonaws.com/WICG/digital-goods/45/392c2ce...rsolomakhin:3ebdec3.html> >>> >>> Design docs >>> >>> https://github.com/WICG/digital-goods/blob/master/explainer.md >>> >>> >>> https://docs.google.com/document/d/1Jbt2Mzt-xg1cWVlFScBQsoX_pE8Kg1gYpulxUSV8FM0/edit >>> >>> Summary >>> >>> We would like to ship a non-breaking addition to the existing Digital >>> Goods API. This change: >>> >>> - >>> >>> Adds to DigitalGoodsService: >>> - >>> >>> Promise<sequence<PurchaseDetails>> listPurchaseHistory(); >>> - >>> >>> Adds to ItemDetails: >>> - >>> >>> ItemType type; >>> - >>> >>> sequence<DOMString> iconUrls; >>> - >>> >>> unsigned short introductoryPriceCycles; >>> - >>> >>> Adds enum ItemType. >>> >>> >>> Use of the new methods/fields will require developers to update >>> supporting code in their apps, such as Android Browser Helper >>> <https://github.com/GoogleChrome/android-browser-helper>. >>> >> >> Am I correct to assume that if developers don't update their code, >> nothing will break? >> >> AFAICT from reading the spec diff, these changes are purely additive. >> LGTM2 assuming Rouslan can verify our understanding. :) >> > > That is correct. If web developers do not update their code, nothing will > break. Updating the supporting code is required only to access the new > features. > >> >>> Blink component >>> >>> Blink>Payments >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPayments> >>> >>> Search tags >>> >>> payments <https://chromestatus.com/features#tags:payments>, billing >>> <https://chromestatus.com/features#tags:billing> >>> >>> TAG review >>> >>> https://github.com/w3ctag/design-reviews/issues/571 >>> >>> TAG review status >>> >>> TAG continues to think of DGAPI as a “product-specific API within one >>> company.” >>> >>> Other issues addressed. >>> >>> Risks Interoperability and Compatibility >>> >>> Similar to Payment Request: this API is used to talk to specific store >>> backends, and so its usage is tailored to the specific store. The reason >>> it's a proposed web standard is so that the same code (which is specific to >>> one store) is portable across browsers. >>> >>> Gecko: No signal ( >>> https://github.com/mozilla/standards-positions/issues/349) Requested >>> 2020-05-27 >>> >>> WebKit: No signal ( >>> https://lists.webkit.org/pipermail/webkit-dev/2021-October/032001.html) >>> Requested 2021-10-08 >>> >>> Web developers: Positive ( >>> https://discourse.wicg.io/t/proposal-web-payments-digital-product-management-api/4350 >>> ) >>> >>> Other signals: rouslan@ presented DGAPI at 2021 TPAC >>> <https://www.w3.org/2021/Talks/rouslan-dgapi-20211028.pdf> (meeting >>> notes <https://www.w3.org/2021/10/28-wpwg-minutes.html#t04>) and at a PWA >>> Dev Sync >>> <https://drive.google.com/file/d/1a_6_QVEQrEeUduc8nPE-uc7PKCr-Yhx7/view> >>> (meeting notes >>> <https://docs.google.com/document/d/1X2j1wKC2T4RONcUGYxGus8Dytv6s2_tVTUSkWDWPza4/edit#heading=h.chc35okxwb9>). >>> Other browser implementers and app stores do not appear to have immediate >>> plans to engage with DGAPI. There were some questions, no objections. >>> >>> Ergonomics >>> >>> Used in tandem with the Payment Request API. >>> >>> WebView Application Risks >>> >>> This API is disabled in WebView. >>> >>> >>> Debuggability >>> >>> We have had several requests from developers to make the API easier to >>> debug, but it is difficult due to the interaction with a backing service >>> based in an app/store context. We are looking for suggestions ( >>> https://github.com/WICG/digital-goods/issues/33) on how we might >>> improve the debuggability of the API. >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>> ? >>> >>> The tests are in >>> //third_party/blink/web_tests/wpt_internal/digital-goods. >>> >>> Flag name >>> >>> DigitalGoodsV2_1 >>> >>> Requires code in //chrome? >>> >>> Yes >>> >>> Tracking bug >>> >>> https://crbug.com/1250604 >>> >>> Launch bug >>> >>> https://crbug.com/1288420 >>> >>> Estimated milestones >>> >>> We would like to ship DGAPI v2.1 in M102. >>> >>> Link to entry on the Chrome Platform Status >>> >>> https://chromestatus.com/feature/5339955595313152 >>> >>> Links to previous Intent discussions >>> >>> Intent to prototype 1.0: >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/vkS3k30lWNs. >>> >>> Intent to experiment 1.0: >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/syI9_M9dANY/m/3lt-QGMHAgAJ >>> . >>> >>> Intent to continue experimenting 1.0: >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/uoTx_cRuL5o. >>> >>> Intent to experiment 2.0: >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/wIYqo3F_Vmo/m/uKw6hDa8BgAJ >>> . >>> >>> Intent to ship 2.0: >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/2pjQ3O2GzDA/m/BqQ7UL6gAwAJ >>> >>> Intent to continue experimenting 2.0: >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/DqnurOUBA9s/m/5H18GilKEQAJ >>> >>> Intent to prototype 2.1: >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/JaNDPCUr1ws/m/JFt-E7ePAQAJ >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMMzaWGfB-SO4%2B0gz9h2Wi%3DKfi-i%2BTGbdK%3DJb3f8KCvxPR2Oow%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMMzaWGfB-SO4%2B0gz9h2Wi%3DKfi-i%2BTGbdK%3DJb3f8KCvxPR2Oow%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXm77Xw%3DJ7Ni0BEuqjyR63tdtf%2Bfj6YZYB5gwdrpRuQnA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXm77Xw%3DJ7Ni0BEuqjyR63tdtf%2Bfj6YZYB5gwdrpRuQnA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUPTTzRam1gAcVnDgo-f2UMA%2B85KdKS0koq0m7CmtGmnw%40mail.gmail.com.
