LGTM2 /Daniel
On 2022-04-22 20:52, 'Tarek ElBahnasawy' via blink-dev wrote:
Hi guys, Any other comments or concerns? Tarek ElBahnasawy Sr. Technical Program Manager Web Platform [email protected] <mailto:[email protected]>On Wed, Apr 20, 2022 at 10:38 PM Yoav Weiss <[email protected]> wrote:LGTM1 On Wednesday, April 20, 2022 at 7:54:48 PM UTC+2 [email protected] wrote: > Is it correct to think that since this intent doesn't change the secure context requirements for the API, this signal is not meaningful here? Yes, this was feedback for the secure context change and isn't relevant here. We decided to communicate the secure context change in a separate intent but forgot to remove the feedback. > More broadly, since the Permission Policy's default will be `*`, the top-level origin would need to change their policy for embedded contexts to lose their permission, right? Correct. On Wednesday, April 20, 2022 at 4:45:26 AM UTC-7 [email protected] wrote: On Wed, Apr 20, 2022 at 3:51 AM 'Tarek ElBahnasawy' via blink-dev <[email protected]> wrote: Contact emails [email protected] Explainer https://hacks.mozilla.org/2020/07/securing-gamepad-api/ <https://hacks.mozilla.org/2020/07/securing-gamepad-api/> Specification https://www.w3.org/TR/gamepad/ <https://www.w3.org/TR/gamepad/> https://github.com/w3c/gamepad/pull/112 <https://github.com/w3c/gamepad/pull/112> Design docs https://docs.google.com/document/d/1Dj_7EpT9ttnI96BuNXtLEJkHEq0orHgoLeYaOBz9xsU/edit?usp=sharing <https://docs.google.com/document/d/1Dj_7EpT9ttnI96BuNXtLEJkHEq0orHgoLeYaOBz9xsU/edit?usp=sharing> Summary Adds a "gamepad" permissions policy-controlled feature. Information about connected gamepads is only provided to contexts that are allowed to access the "gamepad" feature. Default policy allows cross-origin iframes and does not change behavior on existing sites. Note that the Securing Gamepad API <https://hacks.mozilla.org/2020/07/securing-gamepad-api/>article and Chrome Platform Status entry <https://chromestatus.com/feature/5138714634223616>also describe a change to require Secure Context. This intent only applies to the policy-controlled feature. The secure context requirement will be communicated in a separate Intent. Blink component Blink>GamepadAPI <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EGamepadAPI> TAG review N/A Risks Interoperability and Compatibility Firefox initially rolled out this change with the default allowlist set to 'self' which broke some sites that accessed gamepads from a cross-origin iframe. To avoid breakage, the default allowlist was changed to '*' (all) which has the same behavior as the current implementation. Since the behavior is the same we do not anticipate any breakage. Gecko: Shipped in Firefox 82 WebKit: No signals Web developers: Strongly Negative (https://github.com/w3c/gamepad/issues/145 <https://github.com/w3c/gamepad/issues/145>) Chris from Megapixel VR asked not to restrict to secure contexts due to breaking locally hosted (but not localhost) services and the use of self-signed certificates. Is it correct to think that since this intent doesn't change the secure context requirements for the API, this signal is not meaningful here? More broadly, since the Permission Policy's default will be `*`, the top-level origin would need to change their policy for embedded contexts to lose their permission, right? Other signals: None Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>? Yes Flag name chrome://flags/#restrict-gamepad-access Requires code in //chrome? False Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1314563 <https://bugs.chromium.org/p/chromium/issues/detail?id=1314563> Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5138714634223616 <https://chromestatus.com/feature/5138714634223616> Tarek ElBahnasawy Sr. Technical Program Manager Web Platform [email protected]-- You received this message because you are subscribedto the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKfE4fJX8VOe1imhcv1AGZdg7EKMoDeO-_So5OemGv2pCeGiRQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKfE4fJX8VOe1imhcv1AGZdg7EKMoDeO-_So5OemGv2pCeGiRQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKfE4fLqQ5bf7kVD5Dnf0M1%3DY5%2B3WscWTddrXcz9kpO-k-C_yg%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKfE4fLqQ5bf7kVD5Dnf0M1%3DY5%2B3WscWTddrXcz9kpO-k-C_yg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e5d0b8bc-659e-84ad-7b6b-69b0fc73d765%40gmail.com.
