LGTM3 On 6/8/22 3:02 AM, Yoav Weiss wrote:
LGTM2On Wednesday, June 1, 2022 at 5:47:37 PM UTC+2 Alex Russell wrote: On Monday, May 30, 2022 at 7:50:52 AM UTC-7 Khushal Sagar wrote: On Wed, May 25, 2022 at 11:59 AM slightlyoff via Chromestatus <[email protected] <mailto:admin%[email protected]>> wrote: Reserved LGTM1. I'm concerned that the TAG review was filed late and has not resolved. Sorry, this was an error on my part. I was waiting on a spec (after the Intent to Prototype) and missed filing the TAG review once that was ready. I'll make sure to file one as soon as possible going forward. Thanks for the review! No worries. In future, it's always good to think of your explainer as a living document you start *before* your spec. Doing it the other way around is always going to slow things down and makes it harder for folks to engage with the design that aren't themselves spec experts. The process of building support (in the TAG and API OWNERS, not to mention with developers) benefits from having a high-level description of the problem being solved so that we can all understand if it's being solved well and weigh alternatives. That's the big missing part of this design that I'd still like to see produced (considered alternatives). Best, Alex Our process depends on folks getting good guidance from senior engineers with a wide view of the platform and the connections between parts. The only reason I'm not blocking this one until the TAG review finishes is the CSS-centric nature of the feature, but I would not expect to be approving another feature that doesn't have either an explainer by the proposers or a completed TAG review from this team in future.--You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected] <mailto:[email protected]>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/000000000000dfbfb705dfd828c2%40google.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/000000000000dfbfb705dfd828c2%40google.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e154396c-c302-4a79-bf4b-5df957b19e27n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e154396c-c302-4a79-bf4b-5df957b19e27n%40chromium.org?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b625b32c-7aa7-854f-918f-42fa274db900%40chromium.org.
