Thanks! On Thu, Jun 9, 2022 at 11:02 AM Steve Kobes <sko...@chromium.org> wrote:
> This change shouldn't impact Chromium's PDF viewer, which is currently > doing its own gesture detection > <https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/pdf/gesture_detector.ts> > based on wheel and touch events. > > (There has also been some discussion of adapting the PDF viewer to use > "native" scrolling. This change doesn't create any roadblocks for that > effort, since the gesture scroll events would be handled in C++ and not in > JS.) > > On Thu, Jun 9, 2022 at 12:56 PM K. Moon <km...@chromium.org> wrote: > >> It's not quite true that plugins aren't Web-exposed anymore; PDF support >> still appears as a plugin. Is there any impact to PDF viewers? >> >> On Thu, Jun 9, 2022, 9:48 AM Daniel Bratell <bratel...@gmail.com> wrote: >> >>> LGTM3 >>> >>> /Daniel >>> On 2022-06-09 18:20, Chris Harrelson wrote: >>> >>> LGTM2 >>> >>> On Thu, Jun 9, 2022 at 9:18 AM Rick Byers <rby...@chromium.org> wrote: >>> >>>> Oh yikes, these got exposed to the web and we never noticed? Scary. I >>>> may have had a hand in that a long time ago, sorry! I forget the details, >>>> but remember something about NaCL and maybe Flash support for touch >>>> scrolling. Presumably none of that matters anymore now that Flash and NaCL >>>> are gone. >>>> >>>> I can imagine scenarios where they might be useful to have, but I guess >>>> being main thread only makes them pretty useless (almost all gesture >>>> scrolls are threaded these days). Anyway, given the near zero usage, lack >>>> of a spec, main-thread only behavior and lack of evidence >>>> <https://www.google.com/search?q=gesturescrollstart+event&oq=gesturescrollstart+event&aqs=chrome..69i57l2j0i546l2j69i65j69i60l3.4102j1j7&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIGCAEQRRg5MgcIAhAAGKIEMgcIAxAAGKIEMgYIBBBFGEEyBggFEEUYPDIGCAYQRRg8MgYIBxBFGDzSAQg0MTAyajFqN6gCALACAA&sourceid=chrome&ie=UTF-8> >>>> of anyone talking about these events I'd consider this extremely safe to >>>> remove (more of a bug fix than a deprecation). LGTM1 >>>> >>>> Thanks for discovering this and cleaning it up! >>>> >>>> On Thu, Jun 9, 2022 at 9:11 AM Mehdi Kazemi <mehd...@chromium.org> >>>> wrote: >>>> >>>>> Contact emails >>>>> >>>>> >>>>> * sko...@chromium.org <sko...@chromium.org>,mehd...@chromium.org >>>>> <mehd...@chromium.org>,blink-interactions-t...@google.com >>>>> <blink-interactions-t...@google.com> * Explainer >>>>> >>>>> >>>>> * None * Specification >>>>> >>>>> None. Not a standard feature. >>>>> >>>>> Summary >>>>> >>>>> Gesture Scroll DOM events, namely “gesturescrollstart”, >>>>> “gesturescrollupdate” and “gesturescrollend” are non-standard APIs, which >>>>> were added to Blink for use in plugins, but it appears they were also >>>>> exposed to the web unintentionally. Plugins are no longer web-exposed >>>>> since >>>>> the deprecation of Google Native Client (NaCl). >>>>> >>>>> WebKit Bug: https://bugs.webkit.org/show_bug.cgi?id=92281 >>>>> >>>>> Changelog: >>>>> https://bugs.webkit.org/attachment.cgi?id=155046&action=prettypatch >>>>> >>>>> Motivation >>>>> >>>>> Currently, this API doesn’t work in all situations. It only works when >>>>> there is a *non-composited scroller*. These events are related to >>>>> compositing state, and compositing state is not meant to have observable >>>>> behavior impact and in Blink will vary depending on display type and other >>>>> factors. >>>>> >>>>> Blink component >>>>> >>>>> Blink>Scroll >>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component%3ABlink%3EScroll&can=2> >>>>> >>>>> TAG review >>>>> >>>>> TAG review status >>>>> >>>>> Not applicable >>>>> >>>>> Risks >>>>> >>>>> No other engine supports these events, so we do not expect >>>>> interoperability issues. >>>>> >>>>> As for compatibility, usage data from Canary, Dev and Beta channels >>>>> show that usage is very low, around 0.000015% (gesturescrollstart >>>>> <https://chromestatus.com/metrics/feature/timeline/popularity/4220> >>>>> gesturescrollupdate >>>>> <https://chromestatus.com/metrics/feature/timeline/popularity/4221> >>>>> gesturescrollend >>>>> <https://chromestatus.com/metrics/feature/timeline/popularity/4222>). >>>>> For this reason we would like to just remove it, without any deprecation >>>>> period. >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>>> ? >>>>> >>>>> No >>>>> >>>>> >>>>> Requires code in //chrome? >>>>> >>>>> False >>>>> >>>>> >>>>> Tracking bug >>>>> >>>>> https://crbug.com/1293994 >>>>> <https://bugs.chromium.org/p/chromium/issues/detail?id=1293994> >>>>> >>>>> >>>>> Estimated milestones >>>>> >>>>> No milestones specified >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAASN_%3DmnFnKhp7WQNYiVztF%3Dhr1jpzSTo1x02nXZtysnO2GUMQ%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAASN_%3DmnFnKhp7WQNYiVztF%3Dhr1jpzSTo1x02nXZtysnO2GUMQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_BmVOXxKibPwSF%2BNn9u76AUXdE09fjE7ohWVF7iqUvMg%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_BmVOXxKibPwSF%2BNn9u76AUXdE09fjE7ohWVF7iqUvMg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8qg6SbsZNX0SU6JK%3D_7WhsBkuGLpEHpKGpEAXNXnN%3DLA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8qg6SbsZNX0SU6JK%3D_7WhsBkuGLpEHpKGpEAXNXnN%3DLA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/982bc373-1ad8-595a-0433-999d49257cec%40gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/982bc373-1ad8-595a-0433-999d49257cec%40gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACwGi-62FozJigjZEeA%2B0txsS7XFDukKUKzZtB%2B%2BeReVPH79Xg%40mail.gmail.com.
