LGTM2

/Daniel

On 2022-06-15 10:01, Yoav Weiss wrote:
LGTM1

On Tue, Jun 14, 2022 at 6:00 PM 'François Beaufort 🇫🇷' via blink-dev <blink-dev@chromium.org> wrote:


            Contact emails

    fbeauf...@chromium.org, liber...@chromium.org


            Explainer

    https://github.com/w3c/picture-in-picture/blob/main/explainer.md
    <https://github.com/w3c/picture-in-picture/blob/main/explainer.md>


            Specification

    https://w3c.github.io/picture-in-picture/
    <https://w3c.github.io/picture-in-picture/>


            Summary

    The Picture-in-Picture API allows websites to create a floating
    video window that is always on top of other windows so that users
    may continue consuming media while they interact with other sites
    or applications on their device. This change only applies to
    <video> elements.


            Blink component

    Blink>Media>PictureInPicture
    
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EPictureInPicture>


            TAG review

    https://github.com/w3ctag/design-reviews/issues/226
    <https://github.com/w3ctag/design-reviews/issues/226>


            TAG review status

    Issues addressed


            Risks



            Interoperability and Compatibility


    Gecko: Defer
    (https://mozilla.github.io/standards-positions/#picture-in-picture
    <https://mozilla.github.io/standards-positions/#picture-in-picture>)


    WebKit: Positive - Shipped in Safari 13.1
    
(https://developer.apple.com/documentation/safari-release-notes/safari-13_1-release_notes
    
<https://developer.apple.com/documentation/safari-release-notes/safari-13_1-release_notes>)


    Web developers: Positive - Media players have adopted
    Picture-in-Picture (VideoJS
    <https://docs.videojs.com/pictureinpicturetoggle>, Shaka Player
    <https://shaka-player-demo.appspot.com/docs/api/shaka.ui.PipButton.html>)



    Other signals:


            WebView application risks

    None




            Will this feature be supported on all six Blink platforms
            (Windows, Mac, Linux, Chrome OS, Android, and Android
            WebView)?

    No. Android WebView is still not supported.

    This feature was previously shipped for Windows, Mac, Linux, and
    Chrome OS in 2018.
    
https://groups.google.com/a/chromium.org/g/blink-dev/c/ibVPbqBQapU/m/eMblkidrAgAJ
    
<https://groups.google.com/a/chromium.org/g/blink-dev/c/ibVPbqBQapU/m/eMblkidrAgAJ>


    This intent is about requesting approval to ship on Android
    http://crbug.com/964373 <http://crbug.com/964373>


            Is this feature fully tested by web-platform-tests
            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

    Yes. https://wpt.fyi/results/picture-in-picture
    
<https://wpt.fyi/results/picture-in-picture?label=experimental&label=master&aligned>


            Requires code in //chrome?

    Yes


            Tracking bug

    http://crbug.com/964373 <http://crbug.com/964373>


            Sample links

    https://googlechrome.github.io/samples/picture-in-picture/
    <https://googlechrome.github.io/samples/picture-in-picture/>


            Estimated milestones

    105


            Link to entry on the Chrome Platform Status

    https://chromestatus.com/feature/5729206566649856
    <https://chromestatus.com/feature/5729206566649856>


            Links to previous Intent discussions

    Intent to Ship:
    
https://groups.google.com/a/chromium.org/g/blink-dev/c/ibVPbqBQapU/m/eMblkidrAgAJ
    
<https://groups.google.com/a/chromium.org/g/blink-dev/c/ibVPbqBQapU/m/eMblkidrAgAJ>

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5%2BFP_C6D6eHMoUH0ARms8hmKW5icnXb_1UWTChJJOPt0w%40mail.gmail.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5%2BFP_C6D6eHMoUH0ARms8hmKW5icnXb_1UWTChJJOPt0w%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVhH1sQi4Y_zo6N%3DLDC908avWd3CQVjK%3DtXRs-4qaBzgw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVhH1sQi4Y_zo6N%3DLDC908avWd3CQVjK%3DtXRs-4qaBzgw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/169aaaa4-c0d9-0926-5c15-4bba46b5ad9c%40gmail.com.

Reply via email to