2021年6月10日木曜日 1:19:00 UTC+9 Kentaro Hara:
> Thanks for catching the cases! > > As written in the document, the spreadsheet just lists "inactive" owners > detected per the definition and may include false positives. Please assume > the spreadsheet has false positives and feel free to flip "Drop me" to > "Keep me". > > I'll improve the script to reduce the false positives but it's not > possible to make the definition perfect. I'm a bit concerned about making > the script too smart because the smarter the script becomes, the more > strongly it sends a signal that your name should be removed. It will create > more problems than it solves. I prefer keeping the definition simple and > relying on the owners to flip the flag. > > > > On Thu, Jun 10, 2021 at 12:46 AM Wez <w...@chromium.org> wrote: > >> Note that this also does not distinguish per-file OWNERS (typically folks >> with specialist knowledge outside the scope of a directory's general >> ownership) from general directory OWNERS. >> >> e.g. I was listed as a //content/renderer/pepper owner in the >> spreadsheet, whereas I'm actually listed there because of the >> USB-keycode-mapping files. :) >> >> On Wed, 9 Jun 2021 at 16:25, David Dorwin <ddo...@chromium.org> wrote: >> >>> Thanks for doing this. >>> >>> I wanted to share what might be a common source of false positives: This >>> doesn't appear to account for the case where an OWNERS file is in a >>> directory the owner did not touch but is referenced via file:// from a >>> location the owner did touch. For example, the main Fuchsia OWNERS file is >>> at //build/fuchsia/OWNERS, but that specific directory is not updated >>> very often. >>> >>> On Wed, Jun 9, 2021 at 12:26 AM Kentaro Hara <har...@chromium.org> >>> wrote: >>> >>>> Hi >>>> >>>> *TL;DR: I'm planning to clean up "inactive" OWNERS from the >>>> codebase. If you are bcc-ed in this email, it means you are identified as >>>> an "inactive" OWNER of some directory and your name will be removed from >>>> the OWNERS file if you don't take any action. Otherwise, you can stop >>>> reading now.* >>>> >>>> As of 2021 June, Chromium has 4056 OWNERS files containing 6958 names. >>>> To improve the code review latency, I propose cleaning up "inactive" >>>> owners >>>> from the codebase (e.g., see owners marked as "Emeritus" or "Original" >>>> <https://source.chromium.org/search?q=file:OWNERS%20Emeritus&sq=&ss=chromium%2Fchromium%2Fsrc>). >>>> >>>> I ran the process for Blink and it worked successfully. I'm now extending >>>> it to Chromium :) >>>> >>>> I wrote the detailed process in this document >>>> <https://docs.google.com/document/d/13yQfKLcBgKZdO6njEzB-kRdUJcDsZovtOwLZ3rSLU5c/edit#>, >>>> >>>> and the summary is as follows: >>>> >>>> - An "inactive" OWNER is defined as a person who didn't commit or >>>> review any CLs in the directory they own while there were 20+ CLs that >>>> touched the directory in the past 6 months. >>>> >>>> - The "inactive" owners are listed in this spreadsheet >>>> <https://docs.google.com/spreadsheets/d/1vkyGq1lAn_ZhbvzlZvQMKFBLcH9db0xBMFr-ZzWM7no/edit?resourcekey=0-SdWTgtpnTj0ejh7ckA-Xtg#gid=1691428311&fvid=865090936>. >>>> >>>> 462 names are listed and this corresponds to 7% of all owners. *If you >>>> want to stay as an owner (thanks -- I encourage you to stay as an owner >>>> and >>>> contribute!), please flip "Drop me" to "Keep me"*. Otherwise, your >>>> name will be removed soon. If your name is removed accidentally because >>>> you >>>> didn't have a chance to read this email (e.g., a long vacation), you can >>>> just add your name back. I will LGTM the change. >>>> >>>> - //third_party/* (except //third_party/blink/) and //v8/ are out of >>>> the scope because they are separate repositories. >>>> >>>> I tried to answer FAQs in the document >>>> <https://docs.google.com/document/d/13yQfKLcBgKZdO6njEzB-kRdUJcDsZovtOwLZ3rSLU5c/edit#heading=h.j8f0u6kkk11e> >>>> >>>> but feel free to ask any questions! >>>> >>>> Thanks >>>> >>>> -- >>>> Kentaro Hara, Tokyo >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABg10jxSfLxKh1Lf0cuM8xTf4kr2K%3D_ZVB1vWRQj9TvYdmqK1g%40mail.gmail.com >>>> >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABg10jxSfLxKh1Lf0cuM8xTf4kr2K%3D_ZVB1vWRQj9TvYdmqK1g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHD2rshHjmz%2B4H09Wv74E1f468OLN8NNqAmgzJuyoBM-BP9Y1w%40mail.gmail.com >>> >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHD2rshHjmz%2B4H09Wv74E1f468OLN8NNqAmgzJuyoBM-BP9Y1w%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> > > -- > Kentaro Hara, Tokyo > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c63387ee-82d6-4fb3-a6a0-81a4d0864fabn%40chromium.org.
