LGTM2 to ship group and groupToMap (a bit confusing that the summary uses the old names).

/Daniel

On 2022-09-21 06:55, Yoav Weiss wrote:
LGTM1

On Wed, Sep 21, 2022 at 2:30 AM Shu-yu Guo <s...@chromium.org> wrote:


            Contact emails

    s...@chromium.org


            Explainer

    https://github.com/tc39/proposal-array-grouping/blob/main/README.md


            Specification

    https://tc39.es/proposal-array-grouping/


            Summary

    Adds news Array.prototype methods groupBy() and groupByToMap() to
    perform a grouping or bucketing operation.



            Blink component

    Blink>JavaScript>Language
    
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3ELanguage>


            TAG review



            TAG review status

    Not applicable


            Risks



            Interoperability and Compatibility

    Web compat risk due to Sugar. The original proposed name of
    Array.prototype.groupBy was found to be incompatible. See
    https://github.com/tc39/proposal-array-grouping/issues/37
    Currently named `group` and `groupToMap` with no known
    incompatibilities.



    /Gecko/: Shipped/Shipping
    (https://bugzilla.mozilla.org/show_bug.cgi?id=1739648) Firefox
    shipped in Nightly and found a web compat issue, and are
    attempting outreach:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1750812#c5 Method was
    renamed to `group` and `groupToMap`

    /WebKit/: Shipped/Shipping
    (https://bugs.webkit.org/show_bug.cgi?id=234327)

    /Web developers/: Strongly positive
    
(https://twitter.com/rauschma/status/1470854996459769867?s=20&t=DDr_7gzapEKcfF2MbEVzHA
    
<https://twitter.com/rauschma/status/1470854996459769867?s=20&t=DDr_7gzapEKcfF2MbEVzHA>)

    /Other signals/:


            WebView application risks

    Does this intent deprecate or change behavior of existing APIs,
    such that it has potentially high risk for Android WebView-based
    applications?



            Debuggability

    This feature adds two new built-in Array.prototype methods, which
    are debuggable like all other built-in methods.



            Will this feature be supported on all six Blink platforms
            (Windows, Mac, Linux, Chrome OS, Android, and Android
            WebView)?

    Yes


            Is this feature fully tested by web-platform-tests
            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

    Yes


            Flag name

    --harmony-array-grouping


            Requires code in //chrome?

    False


            Tracking bug

    https://bugs.chromium.org/p/v8/issues/detail?id=12499


            Estimated milestones

    DevTrial on desktop         100

    DevTrial on Android         100



            Anticipated spec changes

    Open questions about a feature may be a source of future web
    compat or interop issues. Please list open issues (e.g. links to
    known github issues in the project for the feature specification)
    whose resolution may introduce web compat/interop risk (e.g.,
    changing to naming or structure of the API in a
    non-backward-compatible way).



            Link to entry on the Chrome Platform Status

    https://chromestatus.com/feature/5714791975878656

    This intent message was generated by Chrome Platform Status
    <https://chromestatus.com/>.
-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e_OXi4njvB46nEMzTJzpoGXWEjYXEgo-7-%3DYCuT2EEeew%40mail.gmail.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e_OXi4njvB46nEMzTJzpoGXWEjYXEgo-7-%3DYCuT2EEeew%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUjGX0yL2GmzaNPXFaRiemtz%2Bd9w-SYO4MV_rLAOwnc6g%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUjGX0yL2GmzaNPXFaRiemtz%2Bd9w-SYO4MV_rLAOwnc6g%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/45b9d5f4-cf5e-7b21-3f38-b0c4c4f24601%40gmail.com.

Reply via email to