LGTM3 assuming a quick check of 10 sites on the list doesn't show any significant breakage
On Fri, Oct 28, 2022 at 3:30 PM Mike Taylor <miketa...@chromium.org> wrote: > LGTM2 > > On 10/28/22 3:23 PM, Chris Harrelson wrote: > > LGTM1; please let us know if the spot check turns up any badly broken > sites. > > On Fri, Oct 28, 2022 at 8:46 AM Mike Taylor <miketa...@chromium.org> > wrote: > >> On 10/28/22 11:30 AM, Rick Byers wrote: >> >> On Fri, Oct 28, 2022 at 4:36 AM Manuel Rego Casasnovas <r...@igalia.com> >> wrote: >> >>> >>> Do we know how bad is the breakage in some of the pages that are hitting >>> the new use counter? >>> >> >> Yeah 0.0002% is in the grey zone of being low enough to not be a problem. >> My hunch, given the lack of support in Firefox, is that they're going to >> somehow not actually result in any visual change or maybe result in some >> minor cosmetic issues. In which case I think aligning with Firefox would be >> good and we should ship this. Anders, can you spot check say 10 origins >> from the HTTPArchive list and let us know what you find in terms of >> breakage? If all 10 are unimpacted or have only very minor visual impact, >> then that drops this down to the "usually insignificant" level of potential >> breakage. >> >> Yep, the fact that Gecko never felt a compat need to implement is >> promising. +1 to doing a random sample to get a sense of impact severity. >> >> >> Note that I checked WebView-specific UseCounters for this and they're >> 1/10th of the Android ones, so the risk for WebView is already very low. >> >> On 28/10/2022 09:33, Anders Hartvoll Ruud wrote: >>> > >>> > >>> > On Fri, Oct 28, 2022 at 2:04 AM Mike Taylor <miketa...@chromium.org >>> > <mailto:miketa...@chromium.org>> wrote: >>> > >>> > On 10/27/22 5:41 AM, Anders Hartvoll Ruud wrote: >>> >> On Thu, Oct 27, 2022 at 11:27 AM Manuel Rego Casasnovas >>> >> <r...@igalia.com <mailto:r...@igalia.com>> wrote: >>> >> >>> >> What's the status in other browsers? >>> >> >>> >> * WebKit does not support it (anymore). >>> >> >>> > Could you point to a commit or a bug? I've only been able to find >>> > https://bugs.webkit.org/show_bug.cgi?id=240271 >>> > <https://bugs.webkit.org/show_bug.cgi?id=240271>, which suggests >>> > that the prefixed variants do exist (and devtools will autocomplete >>> > them in the latest Safari Tech Preview 156). >>> > >>> > I went to double-check, and found that /it is/ still supported. My >>> first >>> > test was invalid, my mistake. >>> >>> Could we file a bug or a signals request to see what's the plan from >>> Apple regarding these? >>> >>> Cheers, >>> Rego >>> >>> > >>> > That said, I'm unaware of content that relies on these two >>> > properties (cf. >>> > https://compat.spec.whatwg.org/#propdef--webkit-perspective-origin >>> > < >>> https://compat.spec.whatwg.org/#propdef--webkit-perspective-origin>). >>> > >>> > thanks, >>> > Mike >>> > >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> > Groups "blink-dev" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> > an email to blink-dev+unsubscr...@chromium.org >>> > <mailto:blink-dev+unsubscr...@chromium.org>. >>> > To view this discussion on the web visit >>> > >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKFBnUoo3Xv0iv3L9rX8BJ69TukS_eRkBsjWvhm1Yjd7d053eA%40mail.gmail.com >>> < >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKFBnUoo3Xv0iv3L9rX8BJ69TukS_eRkBsjWvhm1Yjd7d053eA%40mail.gmail.com?utm_medium=email&utm_source=footer >>> >. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f6799f5b-711f-31a9-be0e-56683a8245ef%40igalia.com >>> . >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/94fb36b7-4bae-a647-453c-39983ca6976e%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/94fb36b7-4bae-a647-453c-39983ca6976e%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-tT0ZGhpOHCpu6sFKgh9mUZKuWUJHUvehiEwsdREpPDw%40mail.gmail.com.
