Hey guys! First of all *Great job*!!! Pavel is here ... an ex Mozilla engineer who is from the other side now ... as normal dev :) Can't wait to use this feature and I totally agree that the web need it!!!
On Thursday, October 20, 2022 at 8:32:21 PM UTC+3 Иван Жеков (joneff) wrote: > (I apologise for the off topic) > > A front end developer here -- I can assure you, developers want and need > this feature. Here are few quick examples: > > * alignment: making a an icons, checkboxes (containers) as big as the line > height, thus ensuring correct alignment > * height of currently empty containers: instead of relying on ::before > with zero width whitespace, we can set correct min height, by using lh. Not > to mention that newer versions of some sass preprocessors decode the \ > encoded white space... > * square icon buttons: having the line height as a unit can be used in > computation > * and obviously, making any box as tall as a line of text, or a couple of > lines of text... That helps with implementing design correctly and making > skeleton type components a breeze. > > Or, if a more concrete example is required: in the web interface of google > groups, when I reply / write there are tokens (chips according to Material > guidelines). The icon and remove button are perfect candidates for being > sized with 1lh -- change the font-size, you change the entire thing. > > Like I said, if you deliver, we front end developers will use it right > away! > > -- Ivan > > On Wednesday, October 19, 2022 at 4:37:32 PM UTC+3 [email protected] > wrote: > >> LGTM3 >> >> On 10/19/22 5:23 AM, Yoav Weiss wrote: >> >> LGTM2 >> >> On Wed, Oct 19, 2022 at 11:22 AM Manuel Rego Casasnovas <[email protected]> >> wrote: >> >>> LGTM1 >>> >>> On 17/10/2022 15:52, Rune Lillesveen wrote: >>> > Asking for both lh and rlh: >>> > >>> > https://github.com/WebKit/standards-positions/issues/75 >>> > <https://github.com/WebKit/standards-positions/issues/75> >>> > https://github.com/mozilla/standards-positions/issues/699 >>> > <https://github.com/mozilla/standards-positions/issues/699> >>> >>> WebKit has shipped this and Firefox is positive. >>> >>> Thanks for filling these. >>> >>> Cheers, >>> Rego >>> >> -- >> >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwb34ig5ewG488f88sjYjfN1OUp0z%3DeX3TUjf5RkuZBg%40mail.gmail.com >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUwb34ig5ewG488f88sjYjfN1OUp0z%3DeX3TUjf5RkuZBg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4445d3bb-299d-4733-84fc-c0b4f4f87a5an%40chromium.org.
