LGTM3 On Wed, Nov 9, 2022 at 8:35 AM Philip Jägenstedt <foo...@chromium.org> wrote:
> LGTM2 > > On Wed, Nov 9, 2022 at 5:32 PM Daniel Bratell <bratel...@gmail.com> wrote: > >> LGTM1 >> >> /Daniel >> On 2022-11-08 21:32, Shu-yu Guo wrote: >> >> Contact emails s...@chromium.org >> >> Explainer https://github.com/tc39/proposal-change-array-by-copy >> >> Specification https://tc39.es/proposal-change-array-by-copy >> >> Summary >> >> Provides additional methods on Array.prototype and TypedArray.prototype >> to enable changes on the array by returning a new copy of it with the >> change. >> >> >> Blink component Blink>JavaScript>Language >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3ELanguage> >> >> TAG review TC39 proposal that only touches Array.prototype, without >> other interactions with web APIs. >> >> TAG review status Not applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> No interoperability risk as this is a TC39 proposal implemented in tandem >> by browser engines. Minimal but non-zero web compatibility risk. Any new >> methods on Array.prototype carries with it a web compat risk as many JS >> libraries add their own methods to Array.prototype, and sometimes those >> libraries clash with newly standardized Array.prototype.methods. Sometimes >> JS Arrays are also used as hash maps, and new prototype methods clash with >> existing keys used by the application. No current incompatibilities are >> known or expected. >> >> >> *Gecko*: Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1784092) >> Stage 3 TC39 proposal. Gecko has already implemented. >> >> *WebKit*: Positive (https://bugs.webkit.org/show_bug.cgi?id=234604) >> Stage 3 TC39 proposal. WebKit has already implemented. >> >> *Web developers*: No signals >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> >> Debuggability >> >> Debugged as any other existing Array.prototype method >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? In test262: see https://github.com/tc39/test262/pull/3464 >> >> Flag name --harmony-change-array-by-copy >> >> Requires code in //chrome? False >> >> Tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=12764 >> >> Estimated milestones >> DevTrial on desktop 108 >> DevTrial on Android 108 >> >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5068609911521280 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e8smpdz95tNLTkPAYWQ0OkSCMxR6_S%3Dm0ManQimtO_5uA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAN-e9e8smpdz95tNLTkPAYWQ0OkSCMxR6_S%3Dm0ManQimtO_5uA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/60b4b6df-7569-68d0-5e5f-bd425ffa90e6%40gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/60b4b6df-7569-68d0-5e5f-bd425ffa90e6%40gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYckRz39nKfFQmfFnmxErfWeFTr4yQsXaZiYVdE8UCj%3DCg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYckRz39nKfFQmfFnmxErfWeFTr4yQsXaZiYVdE8UCj%3DCg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9Uq%2B31GaMYKEo3Rref7Ge8Bq20Dy2t9yrJ9bB9x_sMpw%40mail.gmail.com.
