LGTM2 On 12/7/22 4:25 AM, Yoav Weiss wrote:
LGTM1On Tuesday, December 6, 2022 at 4:48:55 AM UTC+1 Seokho Song wrote: Contact emails seo...@chromium.org Explainer https://github.com/DevSDK/css-trigonometric-functions/blob/main/Explainer.md <https://github.com/DevSDK/css-trigonometric-functions/blob/main/Explainer.md>It'd be good to augment the explainer with examples of things that developers want to achieve, and which this would make easier.The current examples are clear, but don't seem extremely useful. Specification https://www.w3.org/TR/css-values-4/#trig-funcs <https://www.w3.org/TR/css-values-4/#trig-funcs> Summary Add trigonometric functions sin(), cos(), tan(), asin(), acos(), atan(), atan2() to CSS math expressions. Resolving relative length on atan2() has tricky problems. So, Using its double value for now. FYR: https://crbug.com/1392594 Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1802744 <https://bugzilla.mozilla.org/show_bug.cgi?id=1802744> Webkit: https://bugs.webkit.org/show_bug.cgi?id=248513 <https://bugs.webkit.org/show_bug.cgi?id=248513> CSSWG: https://github.com/w3c/csswg-drafts/issues/8169 <https://github.com/w3c/csswg-drafts/issues/8169> Blink component Blink>CSS <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> Search tags css <https://chromestatus.com/features#tags:css>, trigonometric function <https://chromestatus.com/features#tags:trigonometric%20function>, sin <https://chromestatus.com/features#tags:sin>, cos <https://chromestatus.com/features#tags:cos>, tan <https://chromestatus.com/features#tags:tan>, asin <https://chromestatus.com/features#tags:asin>, acos <https://chromestatus.com/features#tags:acos>, atan <https://chromestatus.com/features#tags:atan>, atan2 <https://chromestatus.com/features#tags:atan2> TAG review Not required TAG review status Not applicable Risks Interoperability and Compatibility This feature will improve web compatibility, as we are adding support for a feature that WebKit and Gecko already support /Gecko/: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=1774589 <https://bugzilla.mozilla.org/show_bug.cgi?id=1774589>) /WebKit/: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=203311 <https://bugs.webkit.org/show_bug.cgi?id=203311>) /Web developers/: No signals /Other signals/: Debuggability Automatically supported as a CSS feature in DevTools Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? Yes Link to the test suite?I found a few related tests at https://wpt.fyi/results/css/css-values?label=experimental&label=master&alignedAre these the right tests? Are there others? Flag name Requires code in //chrome? False Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1190444 <https://bugs.chromium.org/p/chromium/issues/detail?id=1190444> Launch bug https://bugs.chromium.org/p/chromium/issues/detail?id=1190444 <https://bugs.chromium.org/p/chromium/issues/detail?id=1190444> Estimated milestones 111 Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5165381072191488 <https://chromestatus.com/feature/5165381072191488> Links to previous Intent discussions Intent to prototype: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPzLR4KH9tBj26wbiAC%3DYhshFDYv66fM9LW-ZuPmeSDrzzxEyg%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPzLR4KH9tBj26wbiAC%3DYhshFDYv66fM9LW-ZuPmeSDrzzxEyg%40mail.gmail.com> This intent message was generated by Chrome Platform Status <https://chromestatus.com/>.-- Regards,Seokho --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/694bf412-b766-403e-b6ca-5ce6c6608488n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/694bf412-b766-403e-b6ca-5ce6c6608488n%40chromium.org?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/01795129-3e14-e8fe-2d6c-c60c34cb459a%40chromium.org.
