On Tue, Jan 17, 2023 at 3:48 PM fantasai <[email protected]>
wrote:

> On 1/12/23 22:55, Ian Kilpatrick wrote:
> > Ah true! I didn't consider the <length> values here.
> >
> > To mitigate this forward compat concern we can apply a partial mapping,
> e.g.
> > if the current `vertical-align` property is set, it'll set the
> > `baseline-source` to `auto`.
>
> I think that helps, yeah.
>
> > This should mitigate any forward compat concern here. I'll send a patch
> to do
> > this tomorrow. This will allow us to perform the larger (complex, and
> risky)
> > vertical-align changes in one shot later
>
> One concern I'd have here is that *if* we cannot ship the
> currently-specced
> shorthanding relationship among these properties, we might have to change
> that
> relationship, which could change how vertical-align and baseline-source
> interact as well.
>

I'm not concerned about this compared to the other compat risks with the
expanded vertical-align mapping (for other folks listed above).
This only becomes an issue if we are unable to ship the vertical-align
mapping at a later date, and we decide that baseline-source shouldn't be
attached to vertical-align at all.


> So it would be good to know if we can actually ship the
>    vertical-align -> alignment-baseline + baseline-shift ( +
> baseline-source)
> mapping or not, even if the additional values are not yet supported.
>

I would actually be worried more about as a forward compat risk supporting
additional values later vs. the risk removing the mitigation above for
example.


> ~fantasai
>
> > On Thu, Jan 12, 2023 at 6:20 PM fantasai <[email protected]
> > <mailto:[email protected]>> wrote:
> >
> >     On 1/12/23 17:21, Ian Kilpatrick wrote:
> >      > Some additional context for folks:
> >      >
> >      >   - Shipping the `baseline-source` property separately (this
> intent)
> >     doesn't
> >      > increase/decrease forwards compat risk in a material way -
> specifying
> >     it would
> >      > "win" over anything specified in `vertical-align` once we support
> that
> >      > mapping, and addresses a large web developer concern.
> >
> >     This is incorrect. In an implementation that implements the
> shorthanding
> >     relationship vs an implementation that doesn't, the following two
> >     declarations
> >     will have different effects:
> >
> >     .x {
> >         baseline-source: first;
> >         vertical-align: 10px; /* resets baseline-source to auto, or not
> */
> >     }
> >
> >     ~fantasai
> >
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpRwWVLcQFqQ9b4decDYMqe3_PFtpkP%3DCvXy2nkntBx8Zg%40mail.gmail.com.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to